Commit Graph

7201 Commits

Author SHA1 Message Date
Chris Slowe
fa06747bc3 Events: add target_age_seconds and target_title (for links) to applicable events on the event pipeline
For events with a notion of a `target`, this stores:

  * `target._age` as `target_age_seconds` in seconds.  This is derivable from the event timestamp and the `target_created_ts` but simpler to query if it's denormalized
  * For `Link`s, store the `target.title` as `target_title`.  The primary goal here is to add more context around reports in Interana.

Also add a test for the report event and fixup the existing tests.
2016-02-10 12:24:42 -08:00
Chris Slowe
be5106d4b9 Testing: fixup mocking in feature_test.py and eventcollector_tests.py 2016-02-10 12:23:42 -08:00
Chris Slowe
20f061eab3 Anti-Evil: add listing to drive /r/all/about/reports 2016-02-10 12:10:18 -08:00
13steinj
528cfcf867 Don't translate messages for gold gifts.
Sending a translated message is confusing for the recipient and can theoretically void an anonymous sender's privacy.
2016-02-10 12:02:40 -08:00
MelissaCole
cd8103a3d0 Clear up flat list buttons for deleted posts
Don't allow sharing, saving, or hiding a deleted post. A user can unsave and
unhide a deleted post so that it's not stuck in the user's saved/hidden lists.
2016-02-10 12:02:37 -08:00
Matt Lee
fc8c9a75a4 Sharing: Disable on links with comments disabled.
The share feature is currently broken on promoted links that have comments
disabled. Since the share feature relies on links having a comments thread,
hide it for any link with comments disabled.
2016-02-10 12:02:33 -08:00
Brian Simpson
6145561143 Set attributes on Wrapped search result 2016-02-10 11:58:11 -08:00
Tiffany Dohzen
6d2ce40fea Mod tools: Rename 'links' to 'posts' in menus 2016-02-10 10:54:34 -08:00
Tiffany Dohzen
3dbcba8bf8 Change reddiquette link to content policy on comment/PM compose box 2016-02-10 10:54:26 -08:00
Chad Birch
8031d388cb tdb_cassandra: remove obsolete report functions
These functions are no longer used for anything (and don't even work).
2016-02-09 13:58:36 -07:00
Chad Birch
ec2368a17a Thing/tdb_sql: remove unused get_cols/extra_props
Neither of these are used at all, so this code can be simplified a bit
by dropping them. get_cols was being specifically set to False in the
code so everything related to it being True was completely dead code.
2016-02-09 13:56:31 -07:00
Chad Birch
0d808811b7 Stop checking title for NSFW/NSFL at display-time
As of 156672bed6 we started checking the
title of submissions at submit-time to see if they should be set to
NSFW. Between that and backfilling all existing submissions to have the
NSFW flag set correctly based on their titles, we can now remove the
display-time check.

This will allow moderators and submitters to turn off NSFW even if
"NSFW" or "NSFL" is in the title. This was an annoyance in cases where
the submitter puts something like "(not NSFW)" in the title but then had
the flag stuck on because of the display-time check.
2016-02-09 13:08:20 -07:00
Brian Simpson
49d7c8d1b5 Add tests for CommentBuilder ordering 2016-02-08 13:55:17 -08:00
Brian Simpson
7e4ae8b280 CommentBuilder._get_comments: set order to object
This will let us test the sorting behavior
2016-02-08 13:55:11 -08:00
Jack Lawson
d30471661f Add wiki_enabled to subreddit JSON response
So we know whether or not to show a "wiki" button, include wiki_enabled.
This will be "true" if the wiki is public, or if you are a mod/admin and
the wiki is set to "mod only"; othrewise, it will return "false".
2016-02-08 13:20:45 -08:00
Brian Simpson
d99a0aef49 Stop updating comment scores on sticky change 2016-02-08 09:25:36 -08:00
Jack Lawson
c66c3942c5 Add adzerk_url to example.ini 2016-02-02 14:37:29 -08:00
Zean Tsoi
3e14743ef3 Events collector: add config vars for test_js_key and test_js_secret 2016-02-02 11:55:07 -08:00
David Wick
a510e92c7c analytics.js: Factor out common event data into addContextData 2016-02-01 14:56:46 -08:00
Matt Lee
86b3e71f02 Events: Add frontend expando events 2016-02-01 14:56:42 -08:00
David Wick
306ceff774 Update event-tracker to latest version 2016-02-01 14:51:55 -08:00
David Wick
517a1a49de eventscollector: Use test endpoint if g.debug is True. 2016-02-01 14:50:44 -08:00
Chad Birch
663b00bf1e Create subreddit button: hide if user can't create
We only show the create subreddit button in the sidebar to users whose
account is at least 30 days old, but since there are now some additional
requirements for creating a subreddit, this means that sometimes we end
up showing the button to people that won't be able to successfully
create a subreddit. This keeps the 30-day restriction, but on top of
that also checks that the user's actually going to be able to create
before showing the button.
2016-02-01 12:44:57 -07:00
Daniel Ellis
b7f1b052c8 ip_events: Use TTL on batch mutator. 2016-01-28 15:58:21 -08:00
Chris Slowe
81f5d74cc2 Fix install-reddit.sh to once again work via wget without checkout out the repository 2016-01-28 11:25:54 -08:00
zeantsoi
921c734816 Vagrantfile: Update box url and checksum 2016-01-27 12:31:06 -08:00
Daniel Ellis
45cb444d97 ip_events: Add Cassandra models.
We are storing the date in the column for sorting when querying.

Entries will stay in Cassandra for 90 days.
2016-01-27 11:44:19 -08:00
MelissaCole
816cd3bf03 Subreddit Rules: Fix typos 2016-01-27 11:35:15 -08:00
Brian Simpson
4c6740c6f6 Account.friend_rels_cache: Load data attributes in query
Otherwise we may pollute the cache with un-loaded Account objects.
This is almost guaranteed to happen when Account.friend_rels needs
to load the Accounts with data immediately after calling
Account.friend_rels_cache.
2016-01-27 11:19:26 -08:00
Brian Simpson
2f2998110d Account._by_name_cache: Don't pollute cache with unloaded objects
Set `data=True` on the query so that the retrieved Accounts will
have their data attributes loaded before being set into the cache.
2016-01-27 11:19:20 -08:00
Daniel Ellis
77af64c226 zookeeper: Fix bug when data is None. 2016-01-26 14:35:09 -08:00
Chris Slowe
1d27289e4b update vote tests to use explicit kw arguments for improved readability 2016-01-26 14:28:37 -08:00
MelissaCole
978aeba445 Return 404 for /about/rules in FakeSubreddit 2016-01-25 15:39:15 -08:00
MelissaCole
074d1d0d68 Subreddit Rules: Fix updating the short_name
When the max number of rules are used, the short name wasn't able
to be updated.
2016-01-25 15:12:15 -08:00
MelissaCole
0ba56193bc Subreddit Rules: Handle cases where short_name is None 2016-01-25 15:12:07 -08:00
Matt Lee
6ad231b2ea Subreddit Rules: Fix broken link to rules page
The string formatting inside of the 'subreddit_report_form' template function is causing
the underscore template tag to get escaped, so the link doesn't render properly on the
frontend. Moving the call to 'unsafe' fixes it, and should be safe since 'sr_name' will only ever be the name of a subreddit or the underscore template tag.
2016-01-25 13:17:25 -08:00
Matt Lee
3872db90a7 Subreddit Rules: Unbreak new report form 2016-01-25 13:17:25 -08:00
Matt Lee
adfc5fe48e Subreddit Rules: Make about/rules page update cached rules
Adds methods to the model and collections to generate JSON compatible
with rendering the rules, and updates (or creates) the rules stored in
sessionStorage on page load and on any change.
2016-01-25 13:17:25 -08:00
Matt Lee
e61640acd0 Subreddit Rules: Update styles
Styles the new rule 'kind' inputs and display, and updates their
display text to match the spec.
2016-01-25 13:17:25 -08:00
Matt Lee
a10d837414 Subreddit Rules: Disable other input when site reason is selected 2016-01-25 13:17:25 -08:00
Matt Lee
cfd5dea2cc Subreddit Rules: Remove action-form css class
This is binding some extra event handlers to be bound in
action-forms.js that aren't needed on the new form.
2016-01-25 13:17:25 -08:00
Matt Lee
442557af72 Subreddit Rules: Cache subreddit rules with sessionCache
Should reduce the number of requests that make it to the API.
2016-01-25 13:17:25 -08:00
Matt Lee
71d11a8186 Subreddit Rules: Render report form client side
Refactor the rules templates to enable rendering on the client while
keeping HTML api in place for the time being.
2016-01-25 13:17:25 -08:00
MelissaCole
0b9287e17f Subreddit Rules: Add ability to edit type of rules 2016-01-25 13:17:25 -08:00
MelissaCole
9b30aff2a7 Subreddit Rules: Support separating types for comments and posts 2016-01-25 13:17:25 -08:00
Matt Lee
5ba63efb13 Subreddit Rules: Remove XSS sinks
The initial rendering of the rules is done in mako, but all subsequent
rendering of the rules is done client-side. Using the wrong template
tags here creates an unnecessary vulnerability that could be used to
XSS attack a limited set of users (mods could potentially XSS attack
other mods of the same sub).
2016-01-25 13:17:25 -08:00
MelissaCole
bceac7117c Subreddit rules: Temporarily handle missing created_utc 2016-01-25 13:17:25 -08:00
MelissaCole
a14df90cd7 Subreddit rules: API changes
Change `when` to `created_utc` and add `description_html`.
2016-01-25 13:17:25 -08:00
Matt Lee
117927e49f SubredditRules: Update new report form language. 2016-01-25 13:17:24 -08:00
Matt Lee
ba39e8fdbb SubredditRules: Force modtools.less to rebuild.
Items in LESS_STYLESHEETS do not automatically rebuild when imported files
change. Items in SPRITED_STYLESHEETS automatically build when any other less
file updates, so that works for now.  Stylesheets run through the spriter
will throw an error if they don't actually contain any sprites, so I added a
dummy sprite rule to modtools.less.
2016-01-25 13:17:24 -08:00