github/reddit
1
1
Fork 0
mirror of https://github.com/reddit-archive/reddit.git synced 2026-01-29 08:48:18 -05:00
Code Issues Packages Projects Releases Wiki Activity
3,235 Commits 1 Branch 0 Tags
fe799f350a04f1bdb6c56bc29f87f0aadbd4782c
Commit Graph

3235 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Max Goodman
fe799f350a Minor listing chooser collapse styling tweaks. 2013-07-24 16:53:56 -07:00
Max Goodman
60c0fe5b7c Quick'n'dirty listing chooser bar collapsing. 2013-07-24 16:53:56 -07:00
Max Goodman
7511f9d29a Improve sidebar subreddit list sorting behavior. 
It turns out Backbone fires the 'sort' event after adding new models to a
collection. This allows us to reorder the views in the DOM in one batch
rather than having to insert elements into specific offsets in the DOM,
which breaks when 'add' events are out of order from the collection.
 2013-07-24 16:53:56 -07:00
Max Goodman
57acac7ab0 Fix multi details sidebar collection initial fetch and render. 
The switch from collection reset -> set caused the change handler in
MultiDetails to immediately fire off a refreshListing.

This change causes the collection contents to be loaded before the
instantiation of the view (due to preload), and makes the view handle
initial rendering of the collection contents in its constructor.
 2013-07-24 16:53:56 -07:00
Max Goodman
eeb1d6f2ea TooManySubredditsException -> TooManySubredditsError. 2013-07-24 16:53:56 -07:00
Max Goodman
87375a1219 Return a more apropos error for blocked multi creation. 2013-07-24 16:53:56 -07:00
Max Goodman
c38de1bcaf Add support for batch adding subreddits to a multi. 2013-07-24 16:53:56 -07:00
Max Goodman
0060fca40a Add client-side "tup" util function. 2013-07-24 16:53:56 -07:00
Max Goodman
85e72f5b35 Use "smart update" for MultiReddit subreddits; add back parse flag. 2013-07-24 16:53:56 -07:00
Max Goodman
afeb76cc8a Update LabeledMulti._srs Subreddit objects when adding/removing. 2013-07-24 16:53:56 -07:00
Max Goodman
d4afe5bbc9 Remove unused LabeledMulti.create "sr_props" parameter. 2013-07-24 16:53:56 -07:00
Max Goodman
82deae6e77 Return 201 status in multi API when something is created. 2013-07-24 16:53:56 -07:00
Max Goodman
1b66b59f28 Remove unused multi sr list item class. 
Fixes unintentional styling class name conflict with ".sr-arrow".
 2013-07-24 16:53:56 -07:00
Max Goodman
765087b4b7 Add REST create method that errors if a multi already exists. 2013-07-24 16:53:56 -07:00
Max Goodman
1ac24bf9e6 Modularize multi API JSON formatting function. 2013-07-24 16:53:56 -07:00
Max Goodman
655bff522d Consolidate multi creation forms and don't clobber existing multis. 2013-07-24 16:53:56 -07:00
Max Goodman
c41c7e6cc5 Return a Deferred from preload to mimic jQuery's $.ajax interface. 2013-07-24 16:53:55 -07:00
bsimpson63
ef5cc60910 When adding to multi check for special subreddits and bail out. 2013-07-24 16:53:55 -07:00
bsimpson63
91c7213b76 Safer check for a Subreddit object in sr_props_to_columns. 
Fixes FakeSubreddits not being handled.
 2013-07-24 16:53:55 -07:00
Max Goodman
107af02595 Use escaped form of _.template substitution. 2013-07-24 16:53:55 -07:00
Max Goodman
35669220ef API docs fixes (make route param name styling consistent). 2013-07-24 16:53:55 -07:00
Max Goodman
c0e03687d5 Add "awesomeness goes here" bubble to empty multis. 2013-07-24 16:53:55 -07:00
Max Goodman
4ec9b5d43d Focus add subreddit box after multireddit creation. 2013-07-24 16:53:55 -07:00
Max Goodman
1cfd16ed97 Reduce min height on multi bubbles to remove blank space. 2013-07-24 16:53:55 -07:00
Max Goodman
38486af879 Handle read-only multireddit status on the frontend. 2013-07-24 16:53:55 -07:00
Max Goodman
f3ea04aef0 Add intro widget to listing chooser with sample multireddits. 2013-07-24 16:53:55 -07:00
Max Goodman
3748013c14 Switch to flexible page name positioning for wide logos. 2013-07-24 16:53:55 -07:00
Max Goodman
662de9425c Prevent listing chooser tabs from line wrapping on hover. 2013-07-24 16:53:55 -07:00
Max Goodman
290c461cd9 Wait until multi creation finishes before updating the frontend. 
This prevents displaying erroneously named multis.
 2013-07-24 16:53:55 -07:00
Max Goodman
5cfb5fc4f9 Add input for creating multis in categorize bubble UI. 2013-07-24 16:53:55 -07:00
Max Goodman
1134dce4b8 Properly handle not found multis in VMultiByPath. 2013-07-24 16:53:55 -07:00
Max Goodman
b85db4f99f Add MinimalController request begin hook. 2013-07-24 16:53:55 -07:00
Max Goodman
fb9a4f5b47 authentication: Don't depend on RedditController cookie objects. 
This enables code reuse outside of the RedditController timeline (such
as in the beta mode plugin).
 2013-07-24 16:53:55 -07:00
Max Goodman
f78ffab2e6 Make copies of multireddits private by default. 2013-07-24 16:53:55 -07:00
Max Goodman
fdbb0b8c98 Improve accuracy of listing chooser selected matching. 
This fixes the "front" tab being selected when viewing other users'
multis, among other issues.
 2013-07-24 16:53:55 -07:00
Max Goodman
dfd97d13d5 multi API: Revert to array of subreddit data; return data on PUT. 
I've decided to return to using an array for multi API subreddit data
since it more closely resembles a collection of objects.
 2013-07-24 16:53:55 -07:00
Max Goodman
adb37a1225 Fix error line wrapping glitch when hovering listing chooser create tab. 2013-07-24 16:53:54 -07:00
Max Goodman
8007496321 Improve error messages for invalid multi names. 2013-07-24 16:53:54 -07:00
Max Goodman
a5479b0ac9 Add moderator tab to listing chooser. 2013-07-24 16:53:54 -07:00
Max Goodman
b9d0558cc3 showWorkingDeferred: handle null Deferred object. 2013-07-24 16:53:54 -07:00
Max Goodman
7b92f4b506 Only preload GET requests. 
This fixes multi deletion through the frontend.
 2013-07-24 16:53:54 -07:00
Max Goodman
352eb675db Fix broken preload expiration function. 
>:(
 2013-07-24 16:53:54 -07:00
Max Goodman
b12cafd377 Auto-focus the name field when showing copy form. 2013-07-24 16:53:54 -07:00
Max Goodman
9759934f7a Add multireddit copying to the frontend. 2013-07-24 16:53:54 -07:00
Max Goodman
ac04ea4504 Add multi tab hover slide animation. 2013-07-24 16:53:54 -07:00
Max Goodman
80813ce073 Only show multi info bar subreddit categorize bubbles if logged in. 2013-07-24 16:53:54 -07:00
Max Goodman
6516e74c40 Allow batch setting multi subreddits via the PUT api call. 2013-07-24 16:53:54 -07:00
Max Goodman
d923cdfca0 Use similar sr_props data structure across client and API. 2013-07-24 16:53:54 -07:00
Max Goodman
f1ad4375d1 Increase subreddit count limit accuracy when adding subreddits. 2013-07-24 16:53:54 -07:00
Max Goodman
358f25c6d8 Count subreddits (not properties) in the multi subreddit limit. 2013-07-24 16:53:54 -07:00