github/reitti
1
1
Fork 0
mirror of https://github.com/dedicatedcode/reitti.git synced 2026-01-09 17:37:57 -05:00
Code Issues 6 Packages Projects Releases Wiki Activity

enhancement(#209): add switch to disable the local login form (#220)

Browse Source
This commit is contained in:
Daniel Graf
2025-09-06 09:05:42 +02:00
committed by GitHub
parent e3d9dabb68
commit 114174ead1
6 changed files with 26 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
README.md
View File

@@ -206,6 +206,7 @@ The included `docker-compose.yml` provides a complete setup with:
| `REDIS_USERNAME` | Redis username (optional) | | username |
| `REDIS_PASSWORD` | Redis password (optional) | | password |
| `ADVERTISE_URI` | Routable URL of the instance. Used for federation of multiple instances. (optional) | | https://reitti.lab |
| `DISABLE_LOCAL_LOGIN` | Whether to disable the local login form (username/password) This only works, if OIDC login is configured. | false | true |
| `OIDC_ENABLED` | Whether to enable OIDC sign-ins | false | true |
| `OIDC_CLIENT_ID` | Your OpenID Connect Client ID (from your provider) | | google |
| `OIDC_CLIENT_SECRET` | Your OpenID Connect Client secret (from your provider) | | F0oxfg8b2rp5X97YPS92C2ERxof1oike |

10
src/main/java/com/dedicatedcode/reitti/controller/IllegalConfigurationException.java Normal file
View File

@@ -0,0 +1,10 @@
package com.dedicatedcode.reitti.controller;
import java.util.Arrays;
public class IllegalConfigurationException extends RuntimeException {
public IllegalConfigurationException(String message, String ... suggestions) {
super("\n\nIllegal Configuration detected!\n\n" + message + "\nPossible solutions:\n- " + String.join("\n- ", Arrays.asList(suggestions)));
setStackTrace(new StackTraceElement[0]);
}
}

10
src/main/java/com/dedicatedcode/reitti/controller/WebViewController.java
View File

@@ -10,11 +10,18 @@ import org.springframework.web.bind.annotation.GetMapping;
public class WebViewController {
private final boolean dataManagementEnabled;
private final boolean oidcEnabled;
private final boolean localLoginEnabled;
public WebViewController(@Value("${reitti.data-management.enabled:false}") boolean dataManagementEnabled,
@Value("${reitti.security.oidc.enabled:false}") boolean oidcEnabled) {
@Value("${reitti.security.oidc.enabled:false}") boolean oidcEnabled,
@Value("${reitti.security.local-login.disable:false}") boolean localLoginDisabled) {
this.dataManagementEnabled = dataManagementEnabled;
this.oidcEnabled = oidcEnabled;
this.localLoginEnabled = !localLoginDisabled;
if (!oidcEnabled && localLoginDisabled) {
throw new IllegalConfigurationException("No login possible.", "enable and configured OIDC support", "Enable local-login via 'reitti.security.local-login.disable:false' or 'DISABLE_LOCAL_LOGIN=false'");
}
}
@GetMapping("/")
@@ -30,6 +37,7 @@ public class WebViewController {
@GetMapping("/login")
public String login(Model model) {
model.addAttribute("oidcEnabled", oidcEnabled);
model.addAttribute("localLoginEnabled", localLoginEnabled);
return "login";
}

2
src/main/resources/application-docker.properties
View File

@@ -16,6 +16,8 @@ spring.data.redis.port=${REDIS_PORT:6379}
spring.data.redis.username=${REDIS_USERNAME:}
spring.data.redis.password=${REDIS_PASSWORD:}
reitti.security.local-login.disable=${DISABLE_LOCAL_LOGIN:false}
reitti.security.oidc.enabled=${OIDC_ENABLED:false}
spring.security.oauth2.client.registration.oauth.client-id=${OIDC_CLIENT_ID:}
spring.security.oauth2.client.registration.oauth.client-secret=${OIDC_CLIENT_SECRET:}

2
src/main/resources/application.properties
View File

@@ -47,6 +47,8 @@ server.tomcat.max-part-count=100
# Application specific settings
reitti.server.advertise-uri=
reitti.security.local-login.disable=false
# OAuth configuration
# For now, we only support having one OIDC provider. If you need multiple, create a ticket in the reitti github.
reitti.security.oidc.enabled=false

5
src/main/resources/templates/login.html
View File

@@ -118,7 +118,7 @@
Invalid username or password
</div>
<form th:action="@{/login}" method="post">
<form th:action="@{/login}" method="post" th:if="${localLoginEnabled}">
<div class="form-group">
<label for="username" th:text="#{login.username}">Username</label>
<input type="text" id="username" name="username" required autofocus>
@@ -137,8 +137,7 @@
<button type="submit" th:text="#{login.button}">Login</button>
</form>
<div th:if="${oidcEnabled}">
<hr style="margin: 30px 0; border: none; border-top: 1px solid var(--color-highlight);">
<hr th:if="${localLoginEnabled}" style="margin: 30px 0; border: none; border-top: 1px solid var(--color-highlight);">
<a href="/oauth2/authorization/oauth" style="text-decoration: none;">
<button type="button">Log in with OAuth</button>
</a>