github/reth
1
1
Fork 0
mirror of https://github.com/paradigmxyz/reth.git synced 2026-01-30 09:38:24 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: use replacement transaction hash in PoolError (#6898)

Browse Source
This commit is contained in:
Dan Cline
2024-02-29 17:05:11 -05:00
committed by GitHub
parent 907d8ff127
commit 2df0d91f8d
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
crates/transaction-pool/src/pool/txpool.rs
View File

@@ -546,9 +546,10 @@ impl<T: TransactionOrdering> TxPool<T> {
// Update invalid transactions metric
self.metrics.invalid_transactions.increment(1);
match err {
InsertErr::Underpriced { existing, transaction: _ } => {
Err(PoolError::new(existing, PoolErrorKind::ReplacementUnderpriced))
}
InsertErr::Underpriced { existing: _, transaction } => Err(PoolError::new(
*transaction.hash(),
PoolErrorKind::ReplacementUnderpriced,
)),
InsertErr::FeeCapBelowMinimumProtocolFeeCap { transaction, fee_cap } => {
Err(PoolError::new(
*transaction.hash(),
@@ -1725,8 +1726,8 @@ pub(crate) type InsertResult<T> = Result<InsertOk<T>, InsertErr<T>>;
pub(crate) enum InsertErr<T: PoolTransaction> {
/// Attempted to replace existing transaction, but was underpriced
Underpriced {
#[allow(dead_code)]
transaction: Arc<ValidPoolTransaction<T>>,
#[allow(dead_code)]
existing: TxHash,
},
/// Attempted to insert a blob transaction with a nonce gap