github/reth
1
1
Fork 0
mirror of https://github.com/paradigmxyz/reth.git synced 2026-04-30 03:01:58 -04:00
Code Issues Packages Projects Releases Wiki Activity

perf(trie): replace Box clone with unsafe reborrow in prune (#22516)

Browse Source 
Co-authored-by: Amp <amp@ampcode.com>
This commit is contained in:
Georgios Konstantopoulos
2026-02-24 00:22:52 -08:00
committed by GitHub
parent 3703255d5d
commit 56bb47709c
1 changed files with 18 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
crates/trie/sparse/src/parallel.rs
View File

@@ -1235,8 +1235,14 @@ impl SparseTrie for ParallelSparseTrie {
SparseNode::Branch { state_mask, blinded_mask, blinded_hashes, .. } => {
// For branch nodes at max depth, collapse all children onto them,
if depth == max_depth {
let mut blinded_mask = *blinded_mask;
let mut blinded_hashes = blinded_hashes.clone();
// SAFETY: The branch node fields and the child nodes accessed in the
// loop live in different subtries (parent at max_depth is in the upper
// subtrie, children at max_depth+1 are in lower subtries), so the
// mutable references do not alias.
let state_mask = unsafe { decouple_lt::<TrieMask>(&*state_mask) };
let blinded_mask = unsafe { decouple_lt_mut::<TrieMask>(blinded_mask) };
let blinded_hashes =
unsafe { decouple_lt_mut::<[B256; 16]>(blinded_hashes) };
for nibble in state_mask.iter() {
if blinded_mask.is_bit_set(nibble) {
continue;
@@ -1261,22 +1267,6 @@ impl SparseTrie for ParallelSparseTrie {
blinded_hashes[nibble as usize] = hash;
effective_pruned_roots.push(child);
}
let SparseNode::Branch {
blinded_mask: old_blinded_mask,
blinded_hashes: old_blinded_hashes,
..
} = self
.subtrie_for_path_mut_untracked(&path)
.unwrap()
.nodes
.get_mut(&path)
.unwrap()
else {
unreachable!("expected branch node at path {path:?}");
};
*old_blinded_mask = blinded_mask;
*old_blinded_hashes = blinded_hashes;
} else {
for nibble in state_mask.iter() {
if blinded_mask.is_bit_set(nibble) {
@@ -3545,6 +3535,16 @@ enum SparseTrieUpdatesAction {
InsertUpdated(Nibbles, BranchNodeCompact),
}
/// Changes the lifetime of the given reference.
unsafe fn decouple_lt<'a, T: ?Sized>(x: &T) -> &'a T {
unsafe { core::mem::transmute(x) }
}
/// Changes the lifetime of the given mutable reference.
unsafe fn decouple_lt_mut<'a, T: ?Sized>(x: &mut T) -> &'a mut T {
unsafe { core::mem::transmute(x) }
}
#[cfg(test)]
mod tests {
use super::{