github/reth
1
1
Fork 0
mirror of https://github.com/paradigmxyz/reth.git synced 2026-01-29 00:58:11 -05:00
Code Issues Packages Projects Releases Wiki Activity

docs: extend validate docs (#2300)

Browse Source
This commit is contained in:
Matthias Seitz
2023-04-18 18:33:06 +02:00
committed by GitHub
parent 74063a025f
commit 57d49ab506
2 changed files with 12 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
crates/transaction-pool/src/lib.rs
View File

@@ -185,9 +185,6 @@ where
) -> (TxHash, TransactionValidationOutcome<V::Transaction>) {
let hash = *transaction.hash();
// TODO(mattsse): this is where additional validate checks would go, like banned senders
// etc...
let outcome = self.pool.validator().validate_transaction(origin, transaction).await;
(hash, outcome)

18
crates/transaction-pool/src/validate.rs
View File

@@ -45,18 +45,24 @@ pub trait TransactionValidator: Send + Sync {
/// This will be used by the transaction-pool to check whether the transaction should be
/// inserted into the pool or discarded right away.
///
///
/// Implementers of this trait must ensure that the transaction is correct, i.e. that it
/// complies with at least all static constraints, which includes checking for:
/// Implementers of this trait must ensure that the transaction is well-formed, i.e. that it
/// complies at least all static constraints, which includes checking for:
///
/// * chain id
/// * gas limit
/// * max cost
/// * nonce >= next nonce of the sender
/// * ...
///
/// The transaction pool makes no assumptions about the validity of the transaction at the time
/// of this call before it inserts it. However, the validity of this transaction is still
/// subject to future changes enforced by the pool, for example nonce changes.
/// See [InvalidTransactionError](InvalidTransactionError) for common errors variants.
///
/// The transaction pool makes no additional assumptions about the validity of the transaction
/// at the time of this call before it inserts it into the pool. However, the validity of
/// this transaction is still subject to future (dynamic) changes enforced by the pool, for
/// example nonce or balance changes. Hence, any validation checks must be applied in this
/// function.
///
/// See [EthTransactionValidator] for a reference implementation.
async fn validate_transaction(
&self,
origin: TransactionOrigin,