github/reth
1
1
Fork 0
mirror of https://github.com/paradigmxyz/reth.git synced 2026-01-29 17:18:08 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: reconsider several is_bad_transactions checks (#2450)

Browse Source
This commit is contained in:
Matthias Seitz
2023-04-28 20:54:30 +02:00
committed by GitHub
parent 433ecdcaec
commit 5c5aef0b42
1 changed files with 27 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
crates/transaction-pool/src/error.rs
View File

@@ -80,8 +80,11 @@ impl PoolError {
false
}
PoolError::SpammerExceededCapacity(_, _) => {
// spammer detected
true
// the sender exceeded the slot capacity, we should not penalize the peer for
// sending the tx because we don't know if all the transactions are sent from the
// same peer, there's also a chance that old transactions haven't been cleared yet
// (pool lags behind) and old transaction still occupy a slot in the pool
false
}
PoolError::DiscardedOnInsert(_) => {
// valid tx but dropped due to size constraints
@@ -146,7 +149,28 @@ impl InvalidPoolTransactionError {
// transaction could just have arrived late/early
false
}
_ => true,
InvalidTransactionError::PriorityFeeMoreThenMaxFee |
InvalidTransactionError::GasTooLow |
InvalidTransactionError::GasTooHigh |
InvalidTransactionError::TipAboveFeeCap => {
// these are technically not invalid
false
}
InvalidTransactionError::FeeCapTooLow |
InvalidTransactionError::MaxFeeLessThenBaseFee => {
// dynamic, but not used during validation
false
}
InvalidTransactionError::Eip2930Disabled |
InvalidTransactionError::Eip1559Disabled => {
// settings
false
}
InvalidTransactionError::OldLegacyChainId => true,
InvalidTransactionError::ChainIdMismatch => true,
InvalidTransactionError::GasUintOverflow => true,
InvalidTransactionError::TxTypeNotSupported => true,
InvalidTransactionError::SignerAccountHasBytecode => true,
}
}
InvalidPoolTransactionError::ExceedsGasLimit(_, _) => true,