github/reth
1
1
Fork 0
mirror of https://github.com/paradigmxyz/reth.git synced 2026-04-30 03:01:58 -04:00
Code Issues Packages Projects Releases Wiki Activity

refactor(engine): extract valid_outcome helper to dedup response const (#22669)

Browse Source
This commit is contained in:
stevencartavia
2026-02-27 19:47:36 -06:00
committed by GitHub
parent 9cfa8a9566
commit 648a2b8cf1
1 changed files with 11 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
crates/engine/tree/src/tree/mod.rs
View File

@@ -427,6 +427,14 @@ where
(incoming, outgoing)
}
/// Returns a [`TreeOutcome`] indicating the forkchoice head is valid and canonical.
fn valid_outcome(state: ForkchoiceState) -> TreeOutcome<OnForkChoiceUpdated> {
TreeOutcome::new(OnForkChoiceUpdated::valid(PayloadStatus::new(
PayloadStatusEnum::Valid,
Some(state.head_block_hash),
)))
}
/// Returns a new [`Sender`] to send messages to this type.
pub fn sender(&self) -> Sender<FromEngine<EngineApiRequest<T, N>, N::Block>> {
self.incoming_tx.clone()
@@ -1118,11 +1126,7 @@ where
}
// The head block is already canonical
let outcome = TreeOutcome::new(OnForkChoiceUpdated::valid(PayloadStatus::new(
PayloadStatusEnum::Valid,
Some(state.head_block_hash),
)));
Ok(Some(outcome))
Ok(Some(Self::valid_outcome(state)))
}
/// Applies chain update for the new head block and processes payload attributes.
@@ -1183,12 +1187,7 @@ where
// The head block is already canonical and we're not processing payload attributes,
// so we're not triggering a payload job and can return right away
let outcome = TreeOutcome::new(OnForkChoiceUpdated::valid(PayloadStatus::new(
PayloadStatusEnum::Valid,
Some(state.head_block_hash),
)));
return Ok(Some(outcome));
return Ok(Some(Self::valid_outcome(state)));
}
// Ensure we can apply a new chain update for the head block
@@ -1208,11 +1207,7 @@ where
return Ok(Some(TreeOutcome::new(updated)));
}
let outcome = TreeOutcome::new(OnForkChoiceUpdated::valid(PayloadStatus::new(
PayloadStatusEnum::Valid,
Some(state.head_block_hash),
)));
return Ok(Some(outcome));
return Ok(Some(Self::valid_outcome(state)));
}
Ok(None)