github/reth
1
1
Fork 0
mirror of https://github.com/paradigmxyz/reth.git synced 2026-01-30 01:28:21 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: rpc cap block range correctly (#3791)

Browse Source 
Co-authored-by: Georgios Konstantopoulos <me@gakonst.com>
This commit is contained in:
Matthias Seitz
2023-07-15 16:48:18 +02:00
committed by GitHub
parent da13ef688b
commit 64d58456da
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
crates/rpc/rpc/src/eth/api/fees.rs
View File

@@ -67,9 +67,11 @@ where
return Err(EthApiError::UnknownBlockNumber)
};
// Check that we would not be querying outside of genesis
if end_block < block_count {
return Err(EthApiError::InvalidBlockRange)
// need to add 1 to the end block to get the correct (inclusive) range
let end_block_plus = end_block + 1;
// Ensure that we would not be querying outside of genesis
if end_block_plus < block_count {
block_count = end_block_plus;
}
// If reward percentiles were specified, we need to validate that they are monotonically
@@ -86,7 +88,8 @@ where
//
// Treat a request for 1 block as a request for `newest_block..=newest_block`,
// otherwise `newest_block - 2
let start_block = end_block - block_count + 1;
// SAFETY: We ensured that block count is capped
let start_block = end_block_plus - block_count;
let headers = self.provider().sealed_headers_range(start_block..=end_block)?;
if headers.len() != block_count as usize {
return Err(EthApiError::InvalidBlockRange)