github/reth
1
1
Fork 0
mirror of https://github.com/paradigmxyz/reth.git synced 2026-02-19 03:04:27 -05:00
Code Issues Packages Projects Releases Wiki Activity

refactor(rocksdb): deduplicate first()/last() implementations (#21738)

Browse Source 
Co-authored-by: Georgios Konstantopoulos <me@gakonst.com>
Co-authored-by: Amp <amp@ampcode.com>
This commit is contained in:
YK
2026-02-03 22:33:44 +08:00
committed by GitHub
parent 786140a99d
commit 6b7cc00289
1 changed files with 15 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
crates/storage/provider/src/providers/rocksdb/provider.rs
View File

@@ -821,11 +821,14 @@ impl RocksDBProvider {
Ok(())
}
/// Gets the first (smallest key) entry from the specified table.
pub fn first<T: Table>(&self) -> ProviderResult<Option<(T::Key, T::Value)>> {
/// Retrieves the first or last entry from a table based on the iterator mode.
fn get_boundary<T: Table>(
&self,
mode: IteratorMode<'_>,
) -> ProviderResult<Option<(T::Key, T::Value)>> {
self.execute_with_operation_metric(RocksDBOperation::Get, T::NAME, |this| {
let cf = this.get_cf_handle::<T>()?;
let mut iter = this.0.iterator_cf(cf, IteratorMode::Start);
let mut iter = this.0.iterator_cf(cf, mode);
match iter.next() {
Some(Ok((key_bytes, value_bytes))) => {
@@ -846,29 +849,16 @@ impl RocksDBProvider {
})
}
/// Gets the last (largest key) entry from the specified table.
pub fn last<T: Table>(&self) -> ProviderResult<Option<(T::Key, T::Value)>> {
self.execute_with_operation_metric(RocksDBOperation::Get, T::NAME, |this| {
let cf = this.get_cf_handle::<T>()?;
let mut iter = this.0.iterator_cf(cf, IteratorMode::End);
/// Gets the first (smallest key) entry from the specified table.
#[inline]
pub fn first<T: Table>(&self) -> ProviderResult<Option<(T::Key, T::Value)>> {
self.get_boundary::<T>(IteratorMode::Start)
}
match iter.next() {
Some(Ok((key_bytes, value_bytes))) => {
let key = <T::Key as reth_db_api::table::Decode>::decode(&key_bytes)
.map_err(|_| ProviderError::Database(DatabaseError::Decode))?;
let value = T::Value::decompress(&value_bytes)
.map_err(|_| ProviderError::Database(DatabaseError::Decode))?;
Ok(Some((key, value)))
}
Some(Err(e)) => {
Err(ProviderError::Database(DatabaseError::Read(DatabaseErrorInfo {
message: e.to_string().into(),
code: -1,
})))
}
None => Ok(None),
}
})
/// Gets the last (largest key) entry from the specified table.
#[inline]
pub fn last<T: Table>(&self) -> ProviderResult<Option<(T::Key, T::Value)>> {
self.get_boundary::<T>(IteratorMode::End)
}
/// Creates an iterator over all entries in the specified table.