github/reth
1
1
Fork 0
mirror of https://github.com/paradigmxyz/reth.git synced 2026-04-08 03:01:12 -04:00
Code Issues Packages Projects Releases Wiki Activity

chore: hotfix latest valid hash on canonical block (#2128)

Browse Source
This commit is contained in:
Matthias Seitz
2023-04-05 22:35:16 +02:00
committed by GitHub
parent c1d128eb7a
commit 7eb7f7458a
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
crates/consensus/beacon/src/engine/mod.rs
View File

@@ -153,7 +153,10 @@ where
if pipeline_min_progress < head_block_number {
self.require_pipeline_run(PipelineTarget::Head);
}
PayloadStatus::from_status(PayloadStatusEnum::Valid)
// TODO: most recent valid block in the branch defined by payload and its
// ancestors, not necessarily the head <https://github.com/paradigmxyz/reth/issues/2126>
PayloadStatus::new(PayloadStatusEnum::Valid, Some(state.head_block_hash))
}
Err(error) => {
warn!(target: "consensus::engine", ?state, ?error, "Error canonicalizing the head hash");
@@ -785,7 +788,10 @@ mod tests {
assert_matches!(rx_invalid.await, Ok(Ok(result)) => assert_eq!(result, expected_result));
let rx_valid = env.send_forkchoice_updated(forkchoice);
let expected_result = ForkchoiceUpdated::from_status(PayloadStatusEnum::Valid);
let expected_result = ForkchoiceUpdated::new(PayloadStatus::new(
PayloadStatusEnum::Valid,
Some(block1.hash),
));
assert_matches!(rx_valid.await, Ok(Ok(result)) => assert_eq!(result, expected_result));
assert_matches!(engine_rx.try_recv(), Err(TryRecvError::Empty));