github/reth
1
1
Fork 0
mirror of https://github.com/paradigmxyz/reth.git synced 2026-01-29 09:08:05 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix(disc): check insert result on neighbours response (#1401)

Browse Source
This commit is contained in:
Matthias Seitz
2023-02-16 14:03:19 +01:00
committed by GitHub
parent e97753c768
commit 804d8bf1da
1 changed files with 13 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
crates/net/discv4/src/lib.rs
View File

@@ -1182,20 +1182,25 @@ impl Discv4Service {
let key = kad_key(closest.id);
match self.kbuckets.entry(&key) {
BucketEntry::Absent(entry) => {
// the node's endpoint is not proven yet, so we need to ping it first, on
// success, it will initiate a `FindNode` request.
// In order to prevent that this node is selected again on subsequent responses,
// while the ping is still active, we always mark it as queried.
ctx.mark_queried(closest.id);
let node = NodeEntry::new(closest);
let _ = entry.insert(
match entry.insert(
node,
NodeStatus {
direction: ConnectionDirection::Outgoing,
state: ConnectionState::Disconnected,
},
);
// the node's endpoint is not proven yet, so we need to ping it first, on
// success, it will initiate a `FindNode` request.
// In order to prevent that this node is selected again on subsequent responses,
// while the ping is still active, we already mark it as queried.
ctx.mark_queried(closest.id);
self.try_ping(closest, PingReason::Lookup(closest, ctx.clone()))
) {
BucketInsertResult::Inserted | BucketInsertResult::Pending { .. } => {
// only ping if the node was added to the table
self.try_ping(closest, PingReason::Lookup(closest, ctx.clone()))
}
_ => {}
}
}
BucketEntry::SelfEntry => {
// we received our own node entry