github/reth
1
1
Fork 0
mirror of https://github.com/paradigmxyz/reth.git synced 2026-04-30 03:01:58 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix(exex): instrument ExEx::launch with the span (#10481)

Browse Source
This commit is contained in:
Alexey Shekhirin
2024-08-23 13:53:06 +01:00
committed by GitHub
parent 07bf04df8a
commit 961821cf38
1 changed files with 15 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
crates/node/builder/src/launch/exex.rs
View File

@@ -8,6 +8,7 @@ use reth_node_api::FullNodeComponents;
use reth_primitives::Head;
use reth_provider::CanonStateSubscriptions;
use reth_tracing::tracing::{debug, info};
use tracing::Instrument;
use crate::{common::WithConfigs, exex::BoxedLaunchExEx};
@@ -43,7 +44,7 @@ impl<Node: FullNodeComponents + Clone> ExExLauncher<Node> {
}
let mut exex_handles = Vec::with_capacity(extensions.len());
let mut exexs = Vec::with_capacity(extensions.len());
let mut exexes = Vec::with_capacity(extensions.len());
for (id, exex) in extensions {
// create a new exex handle
@@ -61,26 +62,29 @@ impl<Node: FullNodeComponents + Clone> ExExLauncher<Node> {
};
let executor = components.task_executor().clone();
exexs.push(async move {
exexes.push(async move {
debug!(target: "reth::cli", id, "spawning exex");
let span = reth_tracing::tracing::info_span!("exex", id);
let _enter = span.enter();
// init the exex
let exex = exex.launch(context).await.unwrap();
let exex = exex.launch(context).instrument(span.clone()).await.unwrap();
// spawn it as a crit task
executor.spawn_critical("exex", async move {
info!(target: "reth::cli", "ExEx started");
match exex.await {
Ok(_) => panic!("ExEx {id} finished. ExExes should run indefinitely"),
Err(err) => panic!("ExEx {id} crashed: {err}"),
executor.spawn_critical(
"exex",
async move {
info!(target: "reth::cli", "ExEx started");
match exex.await {
Ok(_) => panic!("ExEx {id} finished. ExExes should run indefinitely"),
Err(err) => panic!("ExEx {id} crashed: {err}"),
}
}
});
.instrument(span),
);
});
}
future::join_all(exexs).await;
future::join_all(exexes).await;
// spawn exex manager
debug!(target: "reth::cli", "spawning exex manager");