github/reth
1
1
Fork 0
mirror of https://github.com/paradigmxyz/reth.git synced 2026-01-30 01:28:21 -05:00
Code Issues Packages Projects Releases Wiki Activity

feat: report different request errors (#3857)

Browse Source
This commit is contained in:
Altuğ Bakan
2023-07-24 21:13:37 +02:00
committed by GitHub
parent 019ead37f2
commit 9b9ae82b2f
1 changed files with 23 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
crates/net/network/src/transactions.rs
View File

@@ -12,7 +12,10 @@ use reth_eth_wire::{
EthVersion, GetPooledTransactions, NewPooledTransactionHashes, NewPooledTransactionHashes66,
NewPooledTransactionHashes68, PooledTransactions, Transactions,
};
use reth_interfaces::{p2p::error::RequestResult, sync::SyncStateProvider};
use reth_interfaces::{
p2p::error::{RequestError, RequestResult},
sync::SyncStateProvider,
};
use reth_metrics::common::mpsc::UnboundedMeteredReceiver;
use reth_network_api::{Peers, ReputationChangeKind};
use reth_primitives::{
@@ -472,10 +475,22 @@ where
}
}
fn report_bad_message(&self, peer_id: PeerId) {
trace!(target: "net::tx", ?peer_id, "Penalizing peer for bad transaction");
fn report_peer(&self, peer_id: PeerId, kind: ReputationChangeKind) {
trace!(target: "net::tx", ?peer_id, ?kind);
self.network.reputation_change(peer_id, kind);
self.metrics.reported_bad_transactions.increment(1);
self.network.reputation_change(peer_id, ReputationChangeKind::BadTransactions);
}
fn on_request_error(&self, peer_id: PeerId, req_err: RequestError) {
let kind = match req_err {
RequestError::UnsupportedCapability => ReputationChangeKind::BadProtocol,
RequestError::Timeout => ReputationChangeKind::Timeout,
RequestError::ChannelClosed | RequestError::ConnectionDropped => {
ReputationChangeKind::Dropped
}
RequestError::BadResponse => ReputationChangeKind::BadTransactions,
};
self.report_peer(peer_id, kind);
}
fn report_already_seen(&self, peer_id: PeerId) {
@@ -492,7 +507,7 @@ where
fn on_bad_import(&mut self, hash: TxHash) {
if let Some(peers) = self.transactions_by_peers.remove(&hash) {
for peer_id in peers {
self.report_bad_message(peer_id);
self.report_peer(peer_id, ReputationChangeKind::BadTransactions);
}
}
}
@@ -537,11 +552,11 @@ where
Poll::Ready(Ok(Ok(txs))) => {
this.import_transactions(req.peer_id, txs.0, TransactionSource::Response);
}
Poll::Ready(Ok(Err(_))) => {
this.report_bad_message(req.peer_id);
Poll::Ready(Ok(Err(req_err))) => {
this.on_request_error(req.peer_id, req_err);
}
Poll::Ready(Err(_)) => {
this.report_bad_message(req.peer_id);
this.on_request_error(req.peer_id, RequestError::ConnectionDropped)
}
}
}