github/reth
1
1
Fork 0
mirror of https://github.com/paradigmxyz/reth.git synced 2026-01-29 00:58:11 -05:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Revert "chore: enable tx inserts via p2p" (#2252)" (#2259)

Browse Source
This commit is contained in:
Matthias Seitz
2023-04-15 01:31:16 +02:00
committed by GitHub
parent 154ece7665
commit adad6d31b4
2 changed files with 7 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
crates/net/network/src/transactions.rs
View File

@@ -528,14 +528,15 @@ where
this.on_good_import(hash);
}
Err(err) => {
if err.is_bad_transaction() {
// if we're syncing and the transaction is bad we ignore it, otherwise we
// penalize the peer that sent the bad transaction with the assumption that the
// peer should have known that this transaction is bad. (e.g. consensus rules)
if err.is_bad_transaction() && !this.network.is_syncing() {
trace!(target: "net::tx", ?err, "Bad transaction import");
// TODO disabled until properly tested
// this.on_bad_import(*err.hash());
this.on_good_import(*err.hash());
} else {
this.on_good_import(*err.hash());
this.on_bad_import(*err.hash());
continue
}
this.on_good_import(*err.hash());
}
}
}

3
crates/transaction-pool/src/error.rs
View File

@@ -113,9 +113,6 @@ pub enum InvalidPoolTransactionError {
/// respect the max_init_code_size.
#[error("Transaction's size {0} exceeds max_init_code_size {1}.")]
ExceedsMaxInitCodeSize(usize, usize),
/// Thrown if the transaction contains an invalid signature
#[error("Invalid sender")]
AccountNotFound,
/// Thrown if the input data of a transaction is greater
/// than some meaningful limit a user might use. This is not a consensus error
/// making the transaction invalid, rather a DOS protection.