github/reth
1
1
Fork 0
mirror of https://github.com/paradigmxyz/reth.git synced 2026-04-08 03:01:12 -04:00
Code Issues Packages Projects Releases Wiki Activity

feat: ensure consistent forkchoice state always (#10144)

Browse Source
This commit is contained in:
Dan Cline
2024-08-06 11:52:01 -04:00
committed by GitHub
parent e24e4c773d
commit c4b5f5e9c9
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
crates/engine/tree/src/tree/mod.rs
View File

@@ -687,6 +687,12 @@ where
if self.state.tree_state.canonical_block_hash() == state.head_block_hash {
trace!(target: "engine", "fcu head hash is already canonical");
// update the safe and finalized blocks and ensure their values are valid
if let Err(outcome) = self.ensure_consistent_forkchoice_state(state) {
// safe or finalized hashes are invalid
return Ok(TreeOutcome::new(outcome))
}
// we still need to process payload attributes if the head is already canonical
if let Some(attr) = attrs {
let tip = self
@@ -709,8 +715,7 @@ where
let tip = chain_update.tip().header.clone();
self.on_canonical_chain_update(chain_update);
// update the safe and finalized blocks and ensure their values are valid, but only
// after the head block is made canonical
// update the safe and finalized blocks and ensure their values are valid
if let Err(outcome) = self.ensure_consistent_forkchoice_state(state) {
// safe or finalized hashes are invalid
return Ok(TreeOutcome::new(outcome))