github/reth
1
1
Fork 0
mirror of https://github.com/paradigmxyz/reth.git synced 2026-01-28 16:48:13 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: Update Return Type for eth_getFilterLogs function as per standard schema (#4323)

Browse Source
This commit is contained in:
Aniket Prajapati
2023-08-23 21:56:46 +05:30
committed by GitHub
parent 96f58d7293
commit c99945ece4
2 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
crates/rpc/rpc-api/src/eth_filter.rs
View File

@@ -23,7 +23,7 @@ pub trait EthFilterApi {
/// Returns all logs matching given filter (in a range 'from' - 'to').
#[method(name = "getFilterLogs")]
async fn filter_logs(&self, id: FilterId) -> RpcResult<Vec<Log>>;
async fn filter_logs(&self, id: FilterId) -> RpcResult<FilterChanges>;
/// Uninstalls filter.
#[method(name = "uninstallFilter")]

7
crates/rpc/rpc/src/eth/filter.rs
View File

@@ -135,7 +135,7 @@ where
/// Returns an error if no matching log filter exists.
///
/// Handler for `eth_getFilterLogs`
pub async fn filter_logs(&self, id: FilterId) -> Result<Vec<Log>, FilterError> {
pub async fn filter_logs(&self, id: FilterId) -> Result<FilterChanges, FilterError> {
let filter = {
let filters = self.inner.active_filters.inner.lock().await;
if let FilterKind::Log(ref filter) =
@@ -148,7 +148,8 @@ where
}
};
self.inner.logs_for_filter(filter).await
let logs = self.inner.logs_for_filter(filter).await?;
Ok(FilterChanges::Logs(logs))
}
}
@@ -187,7 +188,7 @@ where
/// Returns an error if no matching log filter exists.
///
/// Handler for `eth_getFilterLogs`
async fn filter_logs(&self, id: FilterId) -> RpcResult<Vec<Log>> {
async fn filter_logs(&self, id: FilterId) -> RpcResult<FilterChanges> {
trace!(target: "rpc::eth", "Serving eth_getFilterLogs");
Ok(EthFilter::filter_logs(self, id).await?)
}