github/reth
1
1
Fork 0
mirror of https://github.com/paradigmxyz/reth.git synced 2026-01-27 08:08:15 -05:00
Code Issues Packages Projects Releases Wiki Activity

feat(net): Perform graceful network shutdown before dropping network in NetworkManager (#11404)

Browse Source 
Co-authored-by: garwah <garwah@garwah>
This commit is contained in:
garwah
2024-10-02 19:15:12 +10:00
committed by GitHub
parent 7cec526370
commit d5bdc1c8c0
1 changed files with 15 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
crates/net/network/src/manager.rs
View File

@@ -600,14 +600,7 @@ impl NetworkManager {
}
NetworkHandleMessage::Shutdown(tx) => {
// Set connection status to `Shutdown`. Stops node to accept
// new incoming connections as well as sending connection requests to newly
// discovered nodes.
self.swarm.on_shutdown_requested();
// Disconnect all active connections
self.swarm.sessions_mut().disconnect_all(Some(DisconnectReason::ClientQuitting));
// drop pending connections
self.swarm.sessions_mut().disconnect_all_pending();
self.perform_network_shutdown();
let _ = tx.send(());
}
NetworkHandleMessage::ReputationChange(peer_id, kind) => {
@@ -966,10 +959,24 @@ impl NetworkManager {
},
}
self.perform_network_shutdown();
let res = shutdown_hook(self);
drop(graceful_guard);
res
}
/// Performs a graceful network shutdown by stopping new connections from being accepted while
/// draining current and pending connections.
fn perform_network_shutdown(&mut self) {
// Set connection status to `Shutdown`. Stops node from accepting
// new incoming connections as well as sending connection requests to newly
// discovered nodes.
self.swarm.on_shutdown_requested();
// Disconnect all active connections
self.swarm.sessions_mut().disconnect_all(Some(DisconnectReason::ClientQuitting));
// drop pending connections
self.swarm.sessions_mut().disconnect_all_pending();
}
}
impl Future for NetworkManager {