github/reth
1
1
Fork 0
mirror of https://github.com/paradigmxyz/reth.git synced 2026-01-29 17:18:08 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: ensure Signature is ethereum scheme (#2183)

Browse Source
This commit is contained in:
Matthias Seitz
2023-04-11 12:45:10 +02:00
committed by GitHub
parent 26e642d390
commit e0e449d5ff
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
crates/primitives/src/transaction/signature.rs
View File

@@ -47,7 +47,7 @@ impl Signature {
}
/// Decodes the `v`, `r`, `s` values without a RLP header.
/// This will return a chain ID if the `v` value is EIP-155 compatible.
/// This will return a chain ID if the `v` value is [EIP-155](https://github.com/ethereum/EIPs/blob/master/EIPS/eip-155.md) compatible.
pub(crate) fn decode_with_eip155_chain_id(
buf: &mut &[u8],
) -> Result<(Self, Option<u64>), DecodeError> {
@@ -60,8 +60,11 @@ impl Signature {
let chain_id = (v - 35) >> 1;
Ok((Signature { r, s, odd_y_parity }, Some(chain_id)))
} else {
// non-EIP-155 legacy scheme
let odd_y_parity = (v - 27) != 0;
// non-EIP-155 legacy scheme, v = 27 for even y-parity, v = 28 for odd y-parity
if v != 27 && v != 28 {
return Err(DecodeError::Custom("invalid Ethereum signature (V is not 27 or 28)"))
}
let odd_y_parity = v == 28;
Ok((Signature { r, s, odd_y_parity }, None))
}
}