github/reth
1
1
Fork 0
mirror of https://github.com/paradigmxyz/reth.git synced 2026-01-29 00:58:11 -05:00
Code Issues Packages Projects Releases Wiki Activity

bug(senders_stage): Stage done is wrong if range doesn't have tx (#1822)

Browse Source
This commit is contained in:
rakita
2023-03-17 18:50:21 +01:00
committed by GitHub
parent 7ef3f4d68e
commit f34c1dcc35
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
crates/stages/src/stages/sender_recovery.rs
View File

@@ -55,6 +55,7 @@ impl<DB: Database> Stage<DB> for SenderRecoveryStage {
) -> Result<ExecOutput, StageError> {
let ((start_block, end_block), capped) =
exec_or_return!(input, self.commit_threshold, "sync::stages::sender_recovery");
let done = !capped;
// Look up the start index for the transaction range
let start_tx_index = tx.get_block_body(start_block)?.start_tx_id;
@@ -65,7 +66,7 @@ impl<DB: Database> Stage<DB> for SenderRecoveryStage {
// No transactions to walk over
if start_tx_index > end_tx_index {
info!(target: "sync::stages::sender_recovery", start_tx_index, end_tx_index, "Target transaction already reached");
return Ok(ExecOutput { stage_progress: end_block, done: true })
return Ok(ExecOutput { stage_progress: end_block, done })
}
// Acquire the cursor for inserting elements
@@ -107,7 +108,6 @@ impl<DB: Database> Stage<DB> for SenderRecoveryStage {
senders_cursor.append(id, sender)?;
}
let done = !capped;
info!(target: "sync::stages::sender_recovery", stage_progress = end_block, done, "Sync iteration finished");
Ok(ExecOutput { stage_progress: end_block, done })
}