github/reth
1
1
Fork 0
mirror of https://github.com/paradigmxyz/reth.git synced 2026-01-09 07:17:56 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix(payload): clarify PayloadTransactions mark_invalid semantics (#20452)

Browse Source
This commit is contained in:
phrwlk
2025-12-17 10:44:17 +02:00
committed by GitHub
parent c681851ec8
commit f54a8a1ef5
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
crates/payload/util/src/traits.rs
View File

@@ -19,8 +19,11 @@ pub trait PayloadTransactions {
ctx: (),
) -> Option<Self::Transaction>;
/// Exclude descendants of the transaction with given sender and nonce from the iterator,
/// because this transaction won't be included in the block.
/// Marks the transaction identified by `sender` and `nonce` as invalid for this iterator.
///
/// Implementations must ensure that subsequent transactions returned from this iterator do not
/// depend on this transaction. For example, they may choose to stop yielding any further
/// transactions from this sender in the current iteration.
fn mark_invalid(&mut self, sender: Address, nonce: u64);
}
@@ -46,6 +49,9 @@ impl<T> PayloadTransactions for NoopPayloadTransactions<T> {
/// Wrapper struct that allows to convert `BestTransactions` (used in tx pool) to
/// `PayloadTransactions` (used in block composition).
///
/// Note: `mark_invalid` for this type filters out all further transactions from the given sender
/// in the current iteration, mirroring the semantics of `BestTransactions::mark_invalid`.
#[derive(Debug)]
pub struct BestPayloadTransactions<T, I>
where