github/reth
1
1
Fork 0
mirror of https://github.com/paradigmxyz/reth.git synced 2026-01-30 01:28:21 -05:00
Code Issues Packages Projects Releases Wiki Activity

chore: remove redundant parent arg (#2796)

Browse Source
This commit is contained in:
Matthias Seitz
2023-05-23 15:53:17 +02:00
committed by GitHub
parent cf805ae027
commit f5cb6981c7
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
crates/blockchain-tree/src/blockchain_tree.rs
View File

@@ -291,7 +291,7 @@ impl<DB: Database, C: Consensus, EF: ExecutorFactory> BlockchainTree<DB, C, EF>
.is_block_hash_canonical(&parent.hash)
.map_err(|err| InsertBlockError::new(block.block.clone(), err.into()))?
{
return self.try_append_canonical_chain(block, parent)
return self.try_append_canonical_chain(block)
}
// this is another check to ensure that if the block points to a canonical block its block
@@ -326,15 +326,15 @@ impl<DB: Database, C: Consensus, EF: ExecutorFactory> BlockchainTree<DB, C, EF>
/// This tries to append the given block to the canonical chain.
///
/// WARNING: this expects that the block is part of the canonical chain, see
/// [Self::is_block_hash_canonical]. Hence, it is expected that the block can be traced back
/// to the current canonical block.
/// WARNING: this expects that the block is part of the canonical chain: The block's parent is
/// part of the canonical chain (e.g. the block's parent is the latest canonical hash). See also
/// [Self::is_block_hash_canonical].
#[instrument(skip_all, target = "blockchain_tree")]
fn try_append_canonical_chain(
&mut self,
block: SealedBlockWithSenders,
parent: BlockNumHash,
) -> Result<BlockStatus, InsertBlockError> {
let parent = block.parent_num_hash();
let block_num_hash = block.num_hash();
debug!(target: "blockchain_tree", head = ?block_num_hash.hash, ?parent, "Appending block to canonical chain");
// create new chain that points to that block