github/scroll
1
1
Fork 0
mirror of https://github.com/scroll-tech/scroll.git synced 2026-04-23 03:00:50 -04:00
Code Issues Packages Projects Releases Wiki Activity

doc(contracts)/fix(contracts): OZ-L1-M03 WithdrawTrieVerifier Proves Intermediate Nodes (#619)

Browse Source 
Co-authored-by: HAOYUatHZ <37070449+HAOYUatHZ@users.noreply.github.com>
This commit is contained in:
Xi Lin
2023-07-20 15:42:11 +08:00
committed by GitHub
parent e3b451c641
commit 571a577231
1 changed files with 16 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
contracts/src/libraries/verifier/WithdrawTrieVerifier.sol
View File

@@ -2,7 +2,23 @@
pragma solidity ^0.8.0;
// solhint-disable no-inline-assembly
library WithdrawTrieVerifier {
/// @dev Verify the merkle proof given root, leaf node and proof.
///
/// Vulnerability:
/// The initially provided message hash can be hashed with the first hash of the proof,
/// thereby giving an intermediate node of the trie. This can then be used with a shortened
/// proof to pass the verification, which may lead to replayability.
///
/// However, it is designed to verify the withdraw trie in `L2MessageQueue`. The `_hash` given
/// in the parameter is always a leaf node. So we assume the length of proof is correct and
/// cannot be shortened.
/// @param _root The expected root node hash of the withdraw trie.
/// @param _hash The leaf node hash of the withdraw trie.
/// @param _nonce The index of the leaf node from left to right, starting from 0.
/// @param _proof The concatenated merkle proof verified the leaf node.
function verifyMerkleProof(
bytes32 _root,
bytes32 _hash,