github/scroll
1
1
Fork 0
mirror of https://github.com/scroll-tech/scroll.git synced 2026-04-23 03:00:50 -04:00
Code Issues Packages Projects Releases Wiki Activity

Revert "utilize sql operations when updating finalized events"

Browse Source 
This reverts commit 7676594def.
This commit is contained in:
Mengran Lan
2024-06-28 18:32:07 +08:00
parent 7676594def
commit b28c91ba13
1 changed files with 5 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
bridge-history-api/internal/orm/batch_event.go
View File

@@ -73,18 +73,6 @@ func (c *BatchEvent) GetFinalizedBatchesLEBlockHeight(ctx context.Context, block
// InsertOrUpdateBatchEvents inserts a new batch event or updates an existing one based on the BatchStatusType.
func (c *BatchEvent) InsertOrUpdateBatchEvents(ctx context.Context, l1BatchEvents []*BatchEvent) error {
var startFinalizedBatchIndex, endFinalizedBatchIndex uint64
collectFinalizedBatches := func(batchIndex uint64) {
if startFinalizedBatchIndex == 0 {
startFinalizedBatchIndex = batchIndex
} else if batchIndex < startFinalizedBatchIndex {
startFinalizedBatchIndex = batchIndex
}
// end is not inclueded
if endFinalizedBatchIndex <= batchIndex {
endFinalizedBatchIndex = batchIndex + 1
}
}
for _, l1BatchEvent := range l1BatchEvents {
db := c.db
db = db.WithContext(ctx)
@@ -103,8 +91,11 @@ func (c *BatchEvent) InsertOrUpdateBatchEvents(ctx context.Context, l1BatchEvent
case btypes.BatchStatusTypeFinalized:
// After darwin, FinalizeBatch event signals a range of batches are finalized,
// thus losing the batch hash info. Meanwhile, only batch_index is enough to find the target batch when finalizing batches.
endFinalizedBatchIndex = 1
collectFinalizedBatches(l1BatchEvent.BatchIndex)
db = db.Where("batch_index = ?", l1BatchEvent.BatchIndex)
updateFields["batch_status"] = btypes.BatchStatusTypeFinalized
if err := db.Updates(updateFields).Error; err != nil {
return fmt.Errorf("failed to update batch event, error: %w", err)
}
case btypes.BatchStatusTypeReverted:
db = db.Where("batch_index = ?", l1BatchEvent.BatchIndex)
db = db.Where("batch_hash = ?", l1BatchEvent.BatchHash)
@@ -118,20 +109,6 @@ func (c *BatchEvent) InsertOrUpdateBatchEvents(ctx context.Context, l1BatchEvent
}
}
}
// initial end value is 0, this can signal that there are some finalized events
if endFinalizedBatchIndex > 0 {
db := c.db
db = db.WithContext(ctx)
db = db.Model(&BatchEvent{})
updateFields := make(map[string]interface{})
db = db.Where("batch_index >= ?", startFinalizedBatchIndex)
db = db.Where("batch_index < ?", endFinalizedBatchIndex)
db = db.Where("batch_status != ?", btypes.BatchStatusTypeFinalized)
updateFields["batch_status"] = btypes.BatchStatusTypeFinalized
if err := db.Updates(updateFields).Error; err != nil {
return fmt.Errorf("failed to update batch event, error: %w", err)
}
}
return nil
}