github/shiny
1
1
Fork 0
mirror of https://github.com/rstudio/shiny.git synced 2026-04-07 03:00:20 -04:00
Code Issues Packages Projects Releases Wiki Activity

Make sure not to have multiple reset event handlers

Browse Source
This commit is contained in:
Winston Chang
2018-08-07 14:49:47 -05:00
parent 79c5c9f95e
commit 265de66946
1 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
srcjs/output_binding_image.js
View File

@@ -100,10 +100,9 @@ $.extend(imageOutputBinding, {
};
}
$img.off("load.shiny-image-interaction");
// Remove event handlers that were added in previous runs of this function.
$el.off('.image_output');
$img.off('.image_output');
imageutils.initCoordmap($el, opts.coordmap);
@@ -129,7 +128,7 @@ $.extend(imageOutputBinding, {
// When img is reset, do housekeeping: clear $el's mouse listener and
// call the handler's onResetImg callback.
$img.on('reset', clickHandler.onResetImg);
$img.on('reset.image_output', clickHandler.onResetImg);
}
if (opts.dblclickId) {
@@ -140,7 +139,7 @@ $.extend(imageOutputBinding, {
$el.on('dblclick2.image_output', dblclickHandler.mousedown);
$el.on('resize.image_output', dblclickHandler.onResize);
$img.on('reset', dblclickHandler.onResetImg);
$img.on('reset.image_output', dblclickHandler.onResetImg);
}
if (opts.hoverId) {
@@ -151,7 +150,7 @@ $.extend(imageOutputBinding, {
$el.on('mouseout.image_output', hoverHandler.mouseout);
$el.on('resize.image_output', hoverHandler.onResize);
$img.on('reset', hoverHandler.onResetImg);
$img.on('reset.image_output', hoverHandler.onResetImg);
}
if (opts.brushId) {
@@ -169,7 +168,7 @@ $.extend(imageOutputBinding, {
$el.on('mousemove.image_output', brushHandler.mousemove);
$el.on('resize.image_output', brushHandler.onResize);
$img.on('reset', brushHandler.onResetImg);
$img.on('reset.image_output', brushHandler.onResetImg);
}
if (opts.clickId || opts.dblclickId || opts.hoverId || opts.brushId) {