Code review feedback

R/middleware-shiny.R

@@ -1,5 +1,3 @@
-#' @include globals.R
-
 reactLogHandler <- function(req) {
   if (!identical(req$PATH_INFO, '/reactlog'))
     return(NULL)
@@ -37,6 +35,7 @@ sessionHandler <- function(req) {
   return(shinysession$handleRequest(subreq))
 }
 
+#' @include globals.R
 dynamicHandler <- function(filePath, dependencyFiles=filePath) {
   lastKnownTimestamps <- NA
   metaHandler <- function(req) NULL

R/react.R

@@ -9,7 +9,7 @@ Context <- setRefClass(
     .domain = 'ANY'
   ),
   methods = list(
-    initialize = function(domain=domain, label='', type='other', prevId='') {
+    initialize = function(domain, label='', type='other', prevId='') {
       id <<- .getReactiveEnvironment()$nextId()
       .invalidated <<- FALSE
       .invalidateCallbacks <<- list()

R/showcase.R

@@ -1,5 +1,3 @@
-#' @include globals.R
-
 # Given the name of a license, return the appropriate link HTML for the
 # license, which may just be the name of the license if the name is
 # unrecognized.
@@ -146,6 +144,7 @@ showcaseBody <- function(htmlBody) {
 }
 
 # Sets the defaults for showcase mode (for app boot).
+#' @include globals.R
 setShowcaseDefault <- function(showcaseDefault) {
   .globals$showcaseDefault <- showcaseDefault
   .globals$showcaseOverride <- as.logical(showcaseDefault)