github/shiny
1
1
Fork 0
mirror of https://github.com/rstudio/shiny.git synced 2026-04-07 03:00:20 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix #1010: updateSliderInput doesn't update hidden sliders

Browse Source
This commit is contained in:
Joe Cheng
2015-12-08 11:13:18 -08:00
parent 97afb52904
commit 89cd58e4f8
5 changed files with 30 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
inst/www/shared/shiny.js
View File

@@ -3259,6 +3259,14 @@ inputBindings.register(checkboxInputBinding, 'shiny.checkboxInput');
//---------------------------------------------------------------------
// Source file: ../srcjs/input_binding_slider.js
// Necessary to get hidden sliders to send their updated values
function forceIonSliderUpdate(slider) {
if (slider.$cache && slider.$cache.input)
slider.$cache.input.trigger('change');
else
console.log("Couldn't force ion slider to update");
}
var sliderInputBinding = {};
$.extend(sliderInputBinding, textInputBinding, {
find: function(scope) {
@@ -3313,6 +3321,7 @@ $.extend(sliderInputBinding, textInputBinding, {
} else {
slider.update({ from: value });
}
forceIonSliderUpdate(slider);
},
subscribe: function(el, callback) {
$(el).on('change.sliderInputBinding', function(event) {
@@ -3345,6 +3354,7 @@ $.extend(sliderInputBinding, textInputBinding, {
$el.data('updating', true);
try {
slider.update(msg);
forceIonSliderUpdate(slider);
} finally {
$el.data('updating', false);
}
@@ -3456,6 +3466,7 @@ $(document).on('click', '.slider-animate-button', function(evt) {
val.to = val.from + (slider.result.to - slider.result.from);
slider.update(val);
forceIonSliderUpdate(slider);
};
var sliderStep = function() {
// Don't overshoot the end
@@ -3466,6 +3477,7 @@ $(document).on('click', '.slider-animate-button', function(evt) {
val.to = Math.min(slider.result.max, slider.result.to + slider.options.step);
slider.update(val);
forceIonSliderUpdate(slider);
};
// If we're currently at the end, restart

2
inst/www/shared/shiny.js.map
View File

File diff suppressed because one or more lines are too long

8
inst/www/shared/shiny.min.js vendored
View File

File diff suppressed because one or more lines are too long

2
inst/www/shared/shiny.min.js.map
View File

File diff suppressed because one or more lines are too long

12
srcjs/input_binding_slider.js
View File

@@ -1,3 +1,11 @@
// Necessary to get hidden sliders to send their updated values
function forceIonSliderUpdate(slider) {
if (slider.$cache && slider.$cache.input)
slider.$cache.input.trigger('change');
else
console.log("Couldn't force ion slider to update");
}
var sliderInputBinding = {};
$.extend(sliderInputBinding, textInputBinding, {
find: function(scope) {
@@ -52,6 +60,7 @@ $.extend(sliderInputBinding, textInputBinding, {
} else {
slider.update({ from: value });
}
forceIonSliderUpdate(slider);
},
subscribe: function(el, callback) {
$(el).on('change.sliderInputBinding', function(event) {
@@ -84,6 +93,7 @@ $.extend(sliderInputBinding, textInputBinding, {
$el.data('updating', true);
try {
slider.update(msg);
forceIonSliderUpdate(slider);
} finally {
$el.data('updating', false);
}
@@ -195,6 +205,7 @@ $(document).on('click', '.slider-animate-button', function(evt) {
val.to = val.from + (slider.result.to - slider.result.from);
slider.update(val);
forceIonSliderUpdate(slider);
};
var sliderStep = function() {
// Don't overshoot the end
@@ -205,6 +216,7 @@ $(document).on('click', '.slider-animate-button', function(evt) {
val.to = Math.min(slider.result.max, slider.result.to + slider.options.step);
slider.update(val);
forceIonSliderUpdate(slider);
};
// If we're currently at the end, restart