github/shiny
1
1
Fork 0
mirror of https://github.com/rstudio/shiny.git synced 2026-04-29 03:00:45 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: use e.currentTarget instead of this in download link click handler

Browse Source 
Cast to HTMLAnchorElement for precise typing of .id and .href.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
E Nelson
2026-04-24 11:17:07 -04:00
parent 48382c43b4
commit 9366f5d72b
5 changed files with 14 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
inst/www/shared/shiny.js
View File

@@ -3031,13 +3031,14 @@
"click.shinyDownloadLink auxclick.shinyDownloadLink",
"a.shiny-download-link",
function(e4) {
if (this.classList.contains("disabled")) {
const el = e4.currentTarget;
if (el.classList.contains("disabled")) {
e4.preventDefault();
return;
}
const evt = import_jquery25.default.Event("shiny:filedownload");
evt.name = this.id;
evt.href = this.href;
evt.name = el.id;
evt.href = el.href;
(0, import_jquery25.default)(document).trigger(evt);
}
);

4
inst/www/shared/shiny.js.map
View File

File diff suppressed because one or more lines are too long

2
inst/www/shared/shiny.min.js vendored
View File

File diff suppressed because one or more lines are too long

4
inst/www/shared/shiny.min.js.map
View File

File diff suppressed because one or more lines are too long

8
srcts/src/bindings/output/downloadlink.ts
View File

@@ -38,16 +38,18 @@ $(document).on(
"click.shinyDownloadLink auxclick.shinyDownloadLink",
"a.shiny-download-link",
function (e: Event) {
const el = e.currentTarget as HTMLAnchorElement;
// Prevent clicks when the button is disabled.
if ((this as HTMLElement).classList.contains("disabled")) {
if (el.classList.contains("disabled")) {
e.preventDefault();
return;
}
const evt: FileDownloadEvent = $.Event("shiny:filedownload");
evt.name = this.id;
evt.href = this.href;
evt.name = el.id;
evt.href = el.href;
$(document).trigger(evt);
},
);