Joe Cheng
dcb0b0c762
Apply lobstr::cst pruning to deep stack traces too
2018-03-14 14:25:49 -07:00
Joe Cheng
a02c32c153
Hide internal renderPlot reactive from stack trace
2018-03-13 15:49:33 -07:00
Joe Cheng
bb85525793
Use lobstr::cst style tree analysis to further prune stack traces
2018-03-13 15:48:02 -07:00
Winston Chang
6b31cd6aee
Merge pull request #1965 from rstudio/joe/bugfix/plot-dim-error
...
Fix #1964 : renderPlot cache breaks when width/height throw
2018-03-01 11:12:56 -06:00
Joe Cheng
e67a8ba369
Fix #1964 : renderPlot cache breaks when width/height throw
...
Fixed by moving the isolate(getDims()) call into the (effectively)
try/catch that does a non-isolated getDims() if an error occurs
2018-02-28 15:40:55 -08:00
Joe Cheng
133d301925
Merge pull request #1961 from rstudio/fix-date-sliders-bookmarking
...
Fix URL-encoded bookmarking with date/date-time sliders
2018-02-28 14:26:50 -08:00
Joe Cheng
17c40a5d1d
Merge pull request #1960 from rstudio/slider-formatting
...
Don't show commas after decimal mark in sliderInput
2018-02-28 13:01:20 -08:00
Winston Chang
042211e5f6
Grunt
2018-02-28 14:34:09 -06:00
Winston Chang
d12830d700
sliderInput: don't show commas after decimal
2018-02-28 14:33:42 -06:00
Winston Chang
b411c70280
Fix URL-encoded bookmarking with date/date-time sliders
2018-02-27 20:42:11 -06:00
Winston Chang
2bc22cc7d5
Merge pull request #1955 from rstudio/update-slider
...
Update ion.rangeSlider to 2.2.0
2018-02-27 13:21:09 -06:00
Joe Cheng
b4c189c89b
Merge pull request #1956 from rstudio/fix-slider-rounding
...
Avoid rounding errors in sliderInput
2018-02-27 10:55:11 -08:00
Winston Chang
fe3f351a2d
Avoid rounding errors from pretty(). Fixes #1006
2018-02-27 10:50:36 -06:00
Winston Chang
076be9cba7
Remove unused keyboard_step parameter
...
keyboard_step was removed in ion.rangeSlider 2.2.0.
2018-02-26 15:57:30 -06:00
Winston Chang
f28dcd85fb
Update to ion.rangeSlider 2.2.0
2018-02-26 15:57:30 -06:00
Joe Cheng
8e0f17c9d7
Merge pull request #1954 from rstudio/fix-bookmark-restore
...
Look for restore context associated with session
2018-02-26 09:25:33 -08:00
Winston Chang
d73817a0db
Look for restore context associated with session. Fixes #1948
2018-02-26 10:55:38 -06:00
Joe Cheng
11874db825
Remove background-thread branch from httpuv remote
2018-02-16 15:41:32 -08:00
Joe Cheng
5d5a43ce90
Merge pull request #1932 from rstudio/async
...
Async
2018-02-16 07:41:36 -08:00
Winston Chang
75e548caab
For installation of Rtools on Appveyor
2018-02-16 09:15:40 -06:00
Joe Cheng
c901e7ba06
Update TODO-promises.md
2018-02-13 15:23:06 -08:00
Joe Cheng
b1dc3dfca1
Restore label to plotObj reactive
2018-02-09 11:12:46 -08:00
Joe Cheng
ce4ed20c69
Fix remaining failing tests
2018-02-09 11:12:46 -08:00
Joe Cheng
d44df7f860
Stack traces were being lost inside hybrid_chain
2018-02-09 11:12:46 -08:00
Joe Cheng
54353e0e1f
Fix coordmap unit tests
2018-02-09 11:12:46 -08:00
Joe Cheng
1c042b6efb
Add to .Rbuildignore
2018-02-09 11:12:46 -08:00
Joe Cheng
b8df1f29c4
Remove unused function
2018-02-09 11:12:46 -08:00
Joe Cheng
18252f5b03
Use later >= 0.7.1
2018-02-09 11:12:46 -08:00
Joe Cheng
881370f284
Remove extraneous comments
2018-02-09 11:12:46 -08:00
Joe Cheng
35d1747bc3
Don't allow invalidation from a child process
2018-02-09 11:12:46 -08:00
Joe Cheng
91ac89a54e
Update TODOs
2018-02-09 11:12:46 -08:00
Joe Cheng
3c694d9bd9
More robust process identification (thanks @HenrikBengtsson)
2018-02-09 11:12:46 -08:00
Joe Cheng
6a78e9df77
Detect (probably inadvertent) attempts to inherit reactive contexts across processes
...
Example (we want this to fail):
library(shiny)
library(future)
plan(multicore)
r <- reactiveVal(TRUE)
isolate({
f <- future({
r()
})
value(f)
})
2018-02-09 11:12:45 -08:00
Joe Cheng
078c6eb30a
Add TODO
2018-02-09 11:12:45 -08:00
Joe Cheng
d35c6002a6
Respect pixelratio (retina) when redrawing cached images
2018-02-09 11:12:45 -08:00
Joe Cheng
f23fc3beaa
Plots were not respecting pixel ratio (retina)
2018-02-09 11:12:45 -08:00
Joe Cheng
5a352e5ace
Update TODOs
2018-02-09 11:12:45 -08:00
Joe Cheng
27cae0065e
Fix bug where req(cancelOutput=TRUE) would leave things grey
...
This was introduced by some changes to shinyapp.js that were necessary
before async outputs and sync outputs were held/flushed together. Now
that async/sync outputs are held/flushed together, these changes are
not necessary and removing them fixes the problem.
The test app is in shiny-examples/205-async-req. I also moved a test
app from manualtests/async/download.R to shiny-examples/204-async-download.
2018-02-09 11:12:45 -08:00
Joe Cheng
50be2993fa
Add TODO
2018-02-09 11:12:45 -08:00
Joe Cheng
d9ea15e9bc
Update TODOs
2018-02-09 11:12:45 -08:00
Joe Cheng
03b1d45d7e
Make deep stack traces opt-in; fix imports
2018-02-09 11:12:45 -08:00
Joe Cheng
e48d6878c4
Update TODOs
2018-02-09 11:12:45 -08:00
Joe Cheng
1a3b255848
Update TODOs
2018-02-09 11:12:45 -08:00
Joe Cheng
f00aa94d7e
Suspend session during async download operation
2018-02-09 11:12:45 -08:00
Joe Cheng
f7980b19f4
Update TODOs
2018-02-09 11:12:45 -08:00
Joe Cheng
6a1f9677a5
Support async downloadHandler content functions
...
If a downloadHandler content function returns a promise (or future)
then Shiny will wait for the promise to resolve before serving up
the file download.
2018-02-09 11:12:45 -08:00
Joe Cheng
e844bb36a5
Update TODOs
2018-02-09 11:12:45 -08:00
Joe Cheng
ae364adfc2
wip2
2018-02-09 11:12:45 -08:00
Joe Cheng
c14a382b90
wip
2018-02-09 11:12:45 -08:00
Joe Cheng
da9c2beaaf
Update TODO
2018-02-09 11:12:45 -08:00
