Winston Chang
f7c9a8de76
Set font-awesome path directly
2019-05-31 21:10:34 -05:00
Winston Chang
17afce6fa1
Merge pull request #2429 from rstudio/wch-fastmap
...
Use fastmap as backing store for Map class
2019-05-31 15:39:34 -05:00
Winston Chang
8f24d667d6
Unquote key
2019-05-30 15:12:15 -05:00
Winston Chang
5cd4588ef2
Use grep(value=TRUE)
2019-05-30 14:38:05 -05:00
Winston Chang
b0a1821d95
Rebuild shiny.js
2019-05-30 14:32:52 -05:00
Winston Chang
6b835f70e6
Merge pull request #2460 from rstudio/wch-disable-plot-drag
...
Disable dragging of plots with any interactions enabled
2019-05-30 14:32:00 -05:00
Winston Chang
308bc76ac6
Disable dragging of plots with any interactions. Closes #1393 , #2223
2019-05-29 15:16:11 -05:00
Winston Chang
fd843509a1
Fix NEWS formatting
2019-05-29 11:59:13 -05:00
Winston Chang
7691cfdadb
Merge pull request #2446 from nteetor/master
...
New target for `shiny:inputchanged` event
2019-05-29 11:57:55 -05:00
nteetor
1aa9368e54
Update inputchanged news item with pr number, move to improvements
2019-05-23 20:11:44 -04:00
nteetor
180e852fee
Trigger shiny:inputchanged event on related input element ( #2442 )
2019-05-22 20:01:33 -04:00
Alan Dipert
547edd7e32
Fix feature request template
2019-05-21 11:14:02 -07:00
Winston Chang
0b46c63c31
Fix testthat version number
2019-05-16 16:43:01 -05:00
Carson Sievert
9b69ce1988
yarn build
2019-05-14 16:44:33 -05:00
Carson Sievert
57cc44f662
Coordmap info should retain discrete limits ( #2410 )
...
* ggplot2 input brushes should retain discrete range mapping, and be imposed in brushedPoints(), closes #1433
* simplify logic and reduce required storage
* get nearPoints() working as well, cleanup
* only remember scale range if ggplot is facet with a free discrete axis
* Use the scale limits (before the range) since the former is specified, that's what is actually shown on the plot
also, introduce within_brush() helper to consistently handle missing values produced by asNumber()
* also use scale limits in older versions of ggplot2
* DRY
* discrete_mapping -> discrete_limits; better comments
* update test expectation
* a couple unit tests
* update comment to reflect new coordmap data structure
* use unlink() not rm()
* add some tests for specifying scale limits and labels
* Use get_limits() if available
* update news
* better name and comment for new asNumber() argument
2019-05-14 16:34:00 -05:00
Carson Sievert
4eaa9c7ea9
Don't match text inputs with a trailing '-selectized' in their id, fixes #2396 ( #2418 )
...
* Don't match text inputs with a trailing '-selectized' in their id, fixes #2396
* update news
* parentheses
2019-05-14 16:26:32 -05:00
Winston Chang
0b6cdcc826
fastmap moved to r-lib
2019-05-14 11:46:57 -05:00
Winston Chang
7bc0a0ca39
Fix tests that assumed names in a specific order
2019-05-14 10:41:06 -05:00
Winston Chang
1ef2074a10
Fastmap objects can now be saved and loaded
2019-05-14 10:36:37 -05:00
Winston Chang
0747b2a72a
fastmap: exists() was renamed to has()
2019-05-14 10:35:50 -05:00
Alan Dipert
64b3095f2c
Removed redundant section of issue template
2019-05-10 10:07:30 -07:00
Winston Chang
ab82af122f
Merge pull request #2436 from rstudio/alan/issue-templates
...
Add issue templates
2019-05-10 12:05:35 -05:00
Alan Dipert
54fccf2e7c
Incorporate feedback from @wch
2019-05-10 10:01:03 -07:00
Alan Dipert
05e953db3a
Improve bug report template
2019-05-10 08:28:05 -07:00
Alan Dipert
f726835850
Add issue templates
2019-05-09 23:04:19 -07:00
Winston Chang
38d2809131
Convert MemoryCache to use fastmap
2019-05-09 10:20:33 -05:00
Winston Chang
d7718991a6
Import fastmap::fastmap
2019-05-09 10:20:33 -05:00
Winston Chang
32c2bff6eb
Convert ReactiveValues$.metadata to use Map
2019-05-09 10:20:33 -05:00
Winston Chang
555ede03ed
Convert ReactiveValues$.values to use Map
2019-05-08 20:33:52 -05:00
Winston Chang
2a6f218700
Convert ReactiveValues$.dependents to use Map
2019-05-08 20:33:52 -05:00
Winston Chang
b087c19b52
Use fastmap as backing store for Map class
2019-05-08 20:33:52 -05:00
Carson Sievert
6fed1c60ac
update news (should've been done in #2404 )
2019-05-08 16:36:46 -05:00
Carson Sievert
b10f2a5291
yarn build
2019-05-08 16:30:59 -05:00
Winston Chang
a4a49a354e
Merge pull request #2404 from rstudio/inputRateName
...
Fix issue with input rate policies
2019-05-08 16:24:02 -05:00
Carson Sievert
ead23528ca
doSetInput calls setInput (duh) so should have name and type
2019-05-08 16:19:21 -05:00
Carson Sievert
b8644949cc
camelCase for consistency; clarify comment
2019-05-08 16:19:13 -05:00
Carson Sievert
b88e3a64f2
comment on the difference between name_type and name
2019-05-08 16:19:07 -05:00
Carson Sievert
2871b423fd
rename name arg to name_type where relevant in input decorators...
...
this will help to highlight when you should call a method with just the input name instead of both the name and the type
2019-05-08 16:19:02 -05:00
Carson Sievert
562fafbc39
pass inputName to immediateCall() and normalCall()
2019-05-08 16:18:55 -05:00
Carson Sievert
191e0874f8
type is only relevant for public methods setInput() and setRatePolicy()
...
change the name of these arguments to reflect this (name_type)
2019-05-08 16:18:47 -05:00
Carson Sievert
fa5ff7bfa5
Consistently ignore input type in all InputRateDecorator methods
2019-05-08 16:18:39 -05:00
Carson Sievert
82e80ccdeb
InputRateDecorator's setInput method needs to strip of the input's ttype before looking up the input's rate policy, closes #2387
2019-05-08 16:18:19 -05:00
Carson Sievert
ff84cf5a18
update news ( #2428 )
2019-05-08 16:08:20 -05:00
Winston Chang
44843a7768
Merge pull request #2406 from rstudio/null-label
...
Input label updating
2019-05-08 15:52:09 -05:00
Carson Sievert
68eeb338da
Have input labels always include 'control-label' class
2019-05-08 15:15:09 -05:00
Carson Sievert
ea54c17902
merge with master
2019-05-08 15:10:22 -05:00
Barret Schloerke
d5ad7eed40
Merge pull request #2424 from rstudio/joe/bugfix/reactive-value-not-changing
...
Fix rstudio/reactlog#36 : Changes to reactive values not displaying accurately
2019-05-08 12:01:08 -04:00
Joe Cheng
c2430cd3f4
Update NEWS
2019-05-07 09:33:59 -07:00
Joe Cheng
8a0731493f
Fix rstudio/reactlog#36 : Changes to reactive values not displaying accurately
2019-05-07 09:30:59 -07:00
Carson Sievert
07e2b80b5d
merge with master; fix NEWS conflicts
2019-05-03 17:21:06 -05:00