Winston Chang
21fb7959a5
Fix edge case with nested choices. Fixes #560
...
When the set of choices is a list containing a named vector of length 1,
choicesWithNames would return the wrong result.
2014-08-01 16:11:51 -05:00
Yihui Xie
3aa22127e0
a consequence of PR #552 is R 3.0.0
...
those who still wish to install shiny under R 2.15.x may take a look at these instructions: https://gist.github.com/yihui/43a68d811dade1d9e828
2014-08-01 15:28:43 -05:00
Winston Chang
cccdbc05a5
Bump to development version number
2014-07-27 22:22:22 -05:00
Winston Chang
dfa32b7be4
Merge tag 'v/0/10/1'
...
Shiny 0.10.1 released to CRAN
2014-07-27 22:19:44 -05:00
Winston Chang
c7e0bd037a
Merge pull request #552 from rstudio/no-catools
...
Remove caTools dependency
2014-07-25 14:43:15 -05:00
Winston Chang
6c711b76b0
Bump version to 0.10.1
v0.10.1
2014-07-25 14:20:43 -05:00
Winston Chang
9c914f10c4
Merge pull request #553 from wch/hidden-selectize
...
Add custom version of selectize.js to work around Firefox bug
2014-07-25 13:37:08 -05:00
Winston Chang
eda56d118a
Merge pull request #549 from yihui/bugfix/utf8-bom
...
warn against the byte order mark if exists; fixes #545
2014-07-24 16:09:56 -05:00
Winston Chang
02c7351c6d
Add custom version of selectize.js to work around Firefox bug
...
This is a workaround for issue #550 . This version is based on selectize version 0.9.1.
2014-07-24 15:29:23 -05:00
Yihui Xie
ab618235f1
one more check before we use UTF-8: see if there are embedded nul's
2014-07-24 14:48:23 -05:00
Joe Cheng
e4239c924b
Remove caTools dependency
...
Instead, use base64 encoding function from httpuv
2014-07-24 10:37:14 -07:00
Yihui Xie
ffead9ed70
add explanations of skipping *nix when checking encoding, and point to the shiny dev center article
2014-07-24 11:57:46 -05:00
Winston Chang
36aefadced
Merge pull request #550 from rstudio/bugfix/offscreen-shinyapps
...
Deal gracefully with elements that have no computed style available
2014-07-23 11:55:24 -05:00
Jonathan McPherson
75ccfe38ce
update comment with more specific browser notes
2014-07-23 09:43:42 -07:00
Jonathan McPherson
e3cb3fe2e4
deal gracefully with elements that have no computed style available
2014-07-22 14:41:34 -07:00
Yihui Xie
983e7e9b75
warn against the byte order mark if exists; fixes #545
2014-07-22 16:22:50 -05:00
Yihui Xie
3db47c076c
a news item for the optgroup feature
2014-07-18 14:40:58 -05:00
Yihui Xie
eeff285b33
add links to examples in shiny dev center
2014-07-18 14:40:31 -05:00
Yihui Xie
029595f8ea
an edge case selectInput(choices = NULL)
...
firstChoice() may fail with an error "subscript out of bounds"
2014-07-17 15:59:33 -05:00
Yihui Xie
ea2ec27724
bump version
2014-07-17 14:52:26 -05:00
Yihui Xie
f6bf4a416f
Merge pull request #537 from yihui/bugfix/native-encoding
...
Use native encoding internally
2014-07-17 14:49:53 -05:00
Yihui Xie
af978a68e3
tweak the warning message
...
and simply stop() in case the user has set option(encoding = 'UTF-8')
2014-07-17 14:39:21 -05:00
Yihui Xie
89dc1323e1
add a note section about the clickId/hoverId arguments in plotOutput(), since they seem to have been confusing grid graphics users
...
and re-wrap the roxygen comments
2014-07-16 17:27:00 -05:00
Yihui Xie
a4b5f63deb
a single quote ' was omitted here, making the Rd for plotOutput() incomplete since this line was ignored
2014-07-16 17:27:00 -05:00
Winston Chang
feaa6ccff4
Merge pull request #542 from rstudio/feature/select-optgroup
...
Feature/select optgroup (closes #520 )
2014-07-16 17:22:29 -05:00
Winston Chang
7159293337
Use consistent indentation for function definitions
2014-07-16 17:04:22 -05:00
Winston Chang
4a5b31e3a7
Simplify needOptgroup function
2014-07-16 16:57:17 -05:00
Winston Chang
6f1dc89fb3
Enable union merge for NEWS
2014-07-16 16:48:56 -05:00
Yihui Xie
29dd405fe5
the options and ... arguments are no longer needed
2014-07-16 15:50:31 -05:00
Yihui Xie
0f0b0cd3d8
explicitly define updateSelectInput() instead of using the trick to change the options argument of updateInputOptions()
2014-07-16 15:50:08 -05:00
Winston Chang
262528e36a
Add tests for deeper nesting with choicesWithNames
2014-07-16 12:07:13 -05:00
Winston Chang
597e86dd57
Make listify work on nested lists of depth > 1
2014-07-16 12:02:55 -05:00
Winston Chang
b604dba948
Add tests for default selected items
2014-07-16 00:52:29 -05:00
Winston Chang
1837a64bd2
Add tests for selectOptions
2014-07-16 00:51:57 -05:00
Winston Chang
9b413de4d8
selectOptions: handle mixed options and optgroups
2014-07-16 00:51:57 -05:00
Winston Chang
3d77cbd677
Slight clarification of comment
2014-07-16 00:51:57 -05:00
Winston Chang
62176c3218
Add tests for choicesWithNames
2014-07-16 00:51:57 -05:00
Winston Chang
d7a01c32cc
Always convert choices to a (named) list
...
Converting it to a list, and ensuring that it's a named list reduces
many checks elsewhere.
2014-07-16 00:51:57 -05:00
Yihui Xie
cc493fd545
fall back to native encoding on Windows if UTF-8 does not work
2014-07-15 16:05:23 -05:00
Yihui Xie
6b8679454d
factor out .Platform$OS.type == 'windows' as isWindows()
2014-07-15 16:04:02 -05:00
Yihui Xie
1b68d61e54
R CMD check will warn against the possibly missing variables inline and type
2014-07-11 17:36:37 -05:00
Yihui Xie
418de862e6
rename newOptions to config
2014-07-11 14:17:08 -05:00
Yihui Xie
413653858e
inherit doc for updateFooInput() from fooInput()
2014-07-11 14:03:47 -05:00
Yihui Xie
f0886a7556
when we need <optgroup> for the child elements of choices, we just generate it no matter what the child element is
...
e.g. we use <optgroup> for A even if A only has one element: list(A = 'a', B = c('b1', 'b2'))
2014-07-11 14:03:47 -05:00
Yihui Xie
0e2666948f
when choice is not a list, we need to return its first element
2014-07-11 14:03:47 -05:00
Yihui Xie
d2fc851816
make updateSelectInput(), updateCheckboxGroupInput(), and updateRadioButtons() work
...
now session$sendInputMessage() does not send options as the choices data, but as a pre-generated raw HTML string; in shiny.js, we just receive this string, and .append() it to the input after the input is emptied
2014-07-11 14:03:47 -05:00
Yihui Xie
e1fb29c8c5
factor out the code to generate options from checkboxGrouptInput() and radioButtons(), and use the new generator generateOptions() for them
2014-07-11 14:03:47 -05:00
Yihui Xie
fe3158fdd6
validateSelected() does not validate selected for the optgroup case; this function is only for shiny <= 0.9
2014-07-11 14:03:47 -05:00
Yihui Xie
721b26f80b
choicesWithNames() should also consider the optgroup case now: all optgroup nodes must be named
2014-07-11 14:03:47 -05:00
Yihui Xie
d3ecfb22ee
closes #326 : generate <optgroup> when choices is a named list of choices
...
note the nested level of optgroup can be greater than one here, however, the HTML4 spec only allows one level, i.e. optgroup must have select as its direct parent http://stackoverflow.com/q/1037732/559676
2014-07-11 14:03:47 -05:00