Carson
649f382291
Library updates -> Potentially breaking changes
2019-09-20 15:43:38 -05:00
Carson
103a35c81b
review feedback
2019-09-20 15:43:38 -05:00
Carson
5af341bfdb
document
2019-09-20 15:43:38 -05:00
Carson
7c7110cd83
Do nothing if the package isn't installed or meets the version requirement
2019-09-20 15:43:38 -05:00
Carson
c4ea489bff
news feedback
2019-09-20 15:43:38 -05:00
Carson
60b3b6ff03
jquery legacy is 1.12.4, not 1.12.1
2019-09-20 15:43:38 -05:00
Carson
1510dca065
update news
2019-09-20 15:43:38 -05:00
Carson
2c49375928
Provide an option, shiny.jquery.version, to opt-in into jQuery 1.12.1
2019-09-20 15:43:38 -05:00
Carson
f9fc22c48b
Emit an upgrade message if an old version htmlwidgets is installed
2019-09-20 15:43:38 -05:00
Alan Dipert
8d14e7ab04
Merge pull request #2625 from rstudio/fix-selectize-update
...
Fix updateSelectizeInput(), fixes #2624
2019-09-20 12:35:47 -07:00
Alan Dipert
8f2a28a1f2
Fix #2624 by aligning select* input handling of groups with that of updateSelect*
2019-09-19 20:16:36 +00:00
Carson Sievert
e8fb1faec0
Merge pull request #2623 from rstudio/carson/rc-ci
...
Fix travis build for 1.4.0
2019-09-18 13:51:46 -05:00
Carson
0e4874c412
have appveyor run github versions as well
2019-09-18 13:36:22 -05:00
Carson
933630af28
Update stack call test expectation in light of https://github.com/rstudio/promises/commit/9ebad6#diff-1220ed154f06164c0a2d6cc053c1f3c1R134
2019-09-18 13:28:32 -05:00
Carson
ff87098102
Temporarily install rc branches to get Travis passing
2019-09-18 12:58:23 -05:00
Winston Chang
6513a86bbd
Merge pull request #2621 from rstudio/carson/bugfix/avoid-offsetX
...
Use pageX/pageY instead of offsetX/offsetY
2019-09-18 12:42:58 -05:00
Carson
97e296c5d5
Use pageX/pageY instead of offsetX/offsetY to determine if a second click is too far away before triggering a double-click event. Closes #2620
2019-09-17 17:49:20 -05:00
Winston Chang
9f87adf4e8
Merge pull request #2619 from rstudio/wch/eslint-rules
...
Better checking for implicit globals in JS
2019-09-17 15:18:05 -05:00
Joe Cheng
6470b3f08c
Fix 062-submitbutton-demo
...
1) In srcjs/input_rate.js line 284, the global variable `name` was
being written to.
2) In a couple of other places in that file, the global variable
`name` was being read instead of `nameType`--the result of an
incomplete refactor.
Also added an eslint rule to prevent this and other globals from
being read implicitly.
2019-09-17 12:55:47 -07:00
Joe Cheng
d1ba84525e
Update version number inserted by Grunt
2019-09-17 12:41:02 -07:00
Winston Chang
05ad66c464
Better checking for implicit globals
2019-09-17 14:09:11 -05:00
Joe Cheng
a8057b96f3
Update version dependencies
2019-09-13 13:45:45 -07:00
Joe Cheng
a89e809498
Bump version to 1.4.0
2019-09-13 13:01:25 -07:00
Winston Chang
02f7a4fdc9
Rebuild documentation
2019-09-12 18:40:35 -05:00
Carson Sievert
7c7c22a597
Document default values of shiny's options ( #2597 )
...
* Document default values of shiny's options, closes #2558
* A more general description of shiny.port's default
2019-09-12 18:31:07 -05:00
Winston Chang
860fa525a2
Merge pull request #2605 from hadley/notification-id
...
Clarify use of id argument
2019-09-12 18:20:17 -05:00
Carson Sievert
9f0e38a28a
Merge pull request #2601 from rstudio/layoutFamily
...
Layout Rd family
2019-09-12 13:09:00 -07:00
Jeff Allen
f834b7befb
Define what all input functions yield for server ( #2600 )
...
* adding section to roxygen docs for server value of input funcs
* add more server values to roxygen docs
* add more server values
* update more server values in documentation
* Address PR feedback
I reflowed the comments to have a max width of 80 on some files, so there were a flurry of line changes, but the only substantive changes were around Joe's comments.
* Update R/input-slider.R
Co-Authored-By: Hadley Wickham <h.wickham@gmail.com >
* Apply suggestions from code review
Co-Authored-By: Carson Sievert <cpsievert1@gmail.com >
* PR feedback, regenerate docs.
* PR Feedback
* Eliminate extra newline
* passwordInput()'s server value
* varSelectInput()'s server value
* document
2019-09-12 20:02:44 +00:00
Winston Chang
7f3a45fb5b
Merge pull request #2560 from rstudio/barret-reactlog-keybindings
...
Use ctrl/cmd + shift + f3 to mark reactlog and Return a 501 error code if reactlog disabled
2019-09-12 10:29:57 -05:00
Barret Schloerke
b0953e810b
merge master
2019-09-12 10:26:38 -04:00
Hadley Wickham
52a86012e5
Update R/notifications.R
...
Co-Authored-By: Carson Sievert <cpsievert1@gmail.com >
2019-09-12 09:09:09 -05:00
Hadley Wickham
2a06fe6baf
Clarify use of id argument
2019-09-12 08:28:27 -05:00
Carson
6e688d2175
add fillPage() to the family as well
2019-09-11 16:30:25 -05:00
Carson
b610fd1f56
Hadley's feedback
2019-09-11 16:29:48 -05:00
Carson
a4730096f4
code review
2019-09-11 15:23:41 -05:00
leslie-huang
6a02439944
add @ family to all layout functions
2019-09-11 15:15:38 -05:00
Carson Sievert
b889b0d2b0
Merge pull request #2582 from rstudio/barret_showcase_hidden_wide
...
Fix showcase bug where hidden by default on wide window
2019-09-11 10:59:18 -07:00
Carson
ba5733e4a4
add news item
2019-09-11 12:34:20 -05:00
Carson Sievert
2e0221ecfd
Merge pull request #2592 from rstudio/set-min-max
...
Exit early if date parsing fails
2019-09-09 13:55:08 -07:00
Carson
aeded79544
yarn build
2019-09-09 15:43:41 -05:00
Carson
c0a7958e77
update news
2019-09-09 15:18:41 -05:00
Carson
431b194ec2
Exit early if date parsing fails in _setMin() and _setMax(), closes #2591
2019-09-09 13:48:18 -05:00
Joe Cheng
29d24d7e08
Merge pull request #2586 from rstudio/resourcePathChangesOption
...
Suppress resource path changes by default
2019-09-06 13:20:35 -07:00
Winston Chang
3b04c642ae
Bump httpuv version dependency
2019-09-06 11:47:58 -05:00
Winston Chang
609fc5b0c0
Fix typo
2019-09-06 11:46:58 -05:00
Winston Chang
2a8c79b577
Merge pull request #2588 from rstudio/wch-slider-phantom
...
Add try-catch to ion.rangeSlider
2019-09-06 10:52:25 -05:00
Winston Chang
043316e40f
Clarify comments
2019-09-06 10:52:08 -05:00
Joe Cheng
c9d8b987d4
Merge pull request #2522 from rstudio/wch-fix-reactivepoll-leak
...
Fix reactivePoll leak
2019-09-05 16:44:57 -07:00
Joe Cheng
33c5a5c665
Fix unit test
2019-09-05 16:12:07 -07:00
Winston Chang
29c90ba163
Code review fixes
2019-09-05 16:12:07 -07:00