Winston Chang
95173f676d
Merge pull request #2319 from rstudio/joe/misc/constant-time-check
...
Add constant time check for shared secret
2019-02-11 15:22:54 -06:00
Joe Cheng
87d1db1f2b
Fix test
2019-02-11 10:02:40 -08:00
Barret Schloerke
d445f384c7
Merge pull request #2315 from rstudio/reactlogShow
...
Add methods: reactlog, reactlogShow, and reactlogReset. Deprecate showReactLog
2019-02-07 15:05:05 -06:00
Joe Cheng
59dd4b0721
Code review feedback
...
- Rename sharedSecret variables to checkSharedSecret
- Don't perform the digest::digest(). This just means the timing could
give away the length of the secret, but that's OK, there's enough
entropy in the secret even if you know its length.
2019-02-05 14:33:04 -08:00
Joe Cheng
d73c91d4a7
Add unit tests for shared secret check
2019-02-04 14:19:02 -08:00
Joe Cheng
665a66522e
Add constant time check for shared secret
2019-02-04 13:19:47 -08:00
Barret Schloerke
ba1efa65fa
update man file name to reactlog from showReactLog in inst/staticdocs/index.r
2019-02-01 16:29:03 -05:00
Barret Schloerke
64a74692b9
document time for reactlogShow
2019-02-01 16:05:33 -05:00
Barret Schloerke
46cd285dd0
update docs by removing showReactLog/reactlogShow (to reactlog) as much as possible
2019-01-30 16:01:22 -05:00
Barret Schloerke
bcac115c3d
Add methods: reactlog, reactlogShow, and reactlogReset. Depricate showReactLog
...
Update links to help file to not use `showReactLog`, but `reactlogShow`
Use updated reactlog pkg function api of reactlog_*. This may fail right now, but rerun travis when the reactlog code is merged into master.
2019-01-30 12:20:22 -05:00
Barret Schloerke
8ae31eb998
Merge pull request #2107 from schloerke/barret/reactlog
...
Upgraded reactlog logging and support for shinyreactlog rendering
2019-01-11 13:19:14 -05:00
Barret Schloerke
7551a6ae1d
add stats:: to setNames function calls
...
helps pass R CMD check
2019-01-11 13:04:39 -05:00
Barret Schloerke
93be659b1b
merge Remotes
2019-01-11 12:45:59 -05:00
Barret Schloerke
3327878fc2
merged from master
2019-01-11 12:33:31 -05:00
Winston Chang
0b25c7f3c1
Merge pull request #2280 from rstudio/static-file
...
Use httpuv static file serving
2019-01-11 10:56:52 -06:00
Barret Schloerke
b606ba4dd7
added news item for reactlog
2019-01-11 09:43:25 -05:00
Barret Schloerke
f2775f2c1d
update rLog$msg output tests
2018-12-14 16:18:20 -05:00
Barret Schloerke
f06274aec6
fixed bad argument placement
2018-12-14 16:01:25 -05:00
Barret Schloerke
dfa686a3e0
always display the first n chars in a rLog$valueChange or rLog$define
...
capture the value in a try statement of capture.output of str
2018-12-14 15:51:31 -05:00
Barret Schloerke
fe679b5de5
add reactId to rLog$invalidateLater
2018-12-14 15:49:45 -05:00
Barret Schloerke
aa1eb0410c
add force option to retrieving reactive info
2018-12-14 14:10:34 -05:00
Barret Schloerke
1b06bab7ee
add define observer to rLog
2018-12-14 12:05:37 -05:00
Barret Schloerke
0f13056aa2
fix rLog$reset to work as an installed package. added a dummy context reactId (different from noReactId)
2018-12-14 12:05:22 -05:00
Barret Schloerke
beecf60db7
use rLog$reset() instead of initializeReactlog() due to changing global binding error
2018-12-13 17:04:12 -05:00
Barret Schloerke
160a2013bc
fix broken test
2018-12-13 16:52:44 -05:00
Barret Schloerke
b8c636e87e
move the actual setting of the reactiveValues key higher in set command for accurate logging
2018-12-13 16:52:35 -05:00
Barret Schloerke
add40e5926
when calling rlog$define, set a value
2018-12-13 16:51:32 -05:00
Barret Schloerke
960e7f3b24
fix .globals binding issue
2018-12-13 16:50:13 -05:00
Barret Schloerke
3e749f36e8
turn off logging of value in console
2018-12-13 16:50:03 -05:00
Barret Schloerke
8198d99309
add rlog$invalidateLater(runningCtxId, millis, domain)
2018-12-13 14:49:27 -05:00
Barret Schloerke
81de1c8ed4
remove setLabel from ReactiveValues
2018-12-13 14:42:25 -05:00
Barret Schloerke
3eb55e9d9b
update reactiveValues set comments
2018-12-13 14:34:58 -05:00
Barret Schloerke
6b6ac86aea
async start stop rLog should use domain = self
2018-12-13 14:33:29 -05:00
Barret Schloerke
1b45e70cbb
use rLog$noReactId constant
2018-12-13 14:32:40 -05:00
Barret Schloerke
929f7ec235
document
2018-12-13 13:26:49 -05:00
Barret Schloerke
cf28d7e470
init testing for msg logging
2018-12-13 13:26:42 -05:00
Barret Schloerke
b0a00108f3
log, action, then perform invalidate action
2018-12-13 13:26:26 -05:00
Barret Schloerke
01151fc7f8
dummy context should be created every time. allow for id to be passed in
2018-12-13 13:26:12 -05:00
Barret Schloerke
bf8dbc38c7
add a noReactId label and init rLog method
2018-12-13 13:25:53 -05:00
Barret Schloerke
ae0d4d9353
add a default reactId for contexts for clearer msg logs and rLogs
2018-12-13 10:48:32 -05:00
Barret Schloerke
43ec4ae238
add helper functions for msg logger.
2018-12-13 10:48:02 -05:00
Barret Schloerke
c568a8cabe
when updating a value for reactVal or a reactValues key, the context should not be recorded
2018-12-13 10:46:12 -05:00
Barret Schloerke
423bdd8b6b
read reactlog version from description file
2018-12-12 11:27:17 -05:00
Barret Schloerke
1e19ff65e6
fix bad comma usage
2018-12-12 11:04:36 -05:00
Barret Schloerke
a9cf632f53
markTime -> userMark; queueEmpty -> idle
2018-12-12 10:58:28 -05:00
Barret Schloerke
fddf94a341
this check is already covered
2018-12-11 17:23:22 -05:00
Barret Schloerke
203168d261
dec/increment with integers
2018-12-11 17:23:13 -05:00
Barret Schloerke
0e3c3536f8
no need to store messages
2018-12-11 17:22:59 -05:00
Barret Schloerke
45b2b7e24f
use curly brackets for all function defs
2018-12-11 17:22:33 -05:00
Barret Schloerke
88f177b065
use class brackets for R6 def
2018-12-11 17:22:09 -05:00
