Joe Cheng
a89e809498
Bump version to 1.4.0
2019-09-13 13:01:25 -07:00
Winston Chang
02f7a4fdc9
Rebuild documentation
2019-09-12 18:40:35 -05:00
Carson Sievert
7c7c22a597
Document default values of shiny's options ( #2597 )
...
* Document default values of shiny's options, closes #2558
* A more general description of shiny.port's default
2019-09-12 18:31:07 -05:00
Winston Chang
860fa525a2
Merge pull request #2605 from hadley/notification-id
...
Clarify use of id argument
2019-09-12 18:20:17 -05:00
Carson Sievert
9f0e38a28a
Merge pull request #2601 from rstudio/layoutFamily
...
Layout Rd family
2019-09-12 13:09:00 -07:00
Jeff Allen
f834b7befb
Define what all input functions yield for server ( #2600 )
...
* adding section to roxygen docs for server value of input funcs
* add more server values to roxygen docs
* add more server values
* update more server values in documentation
* Address PR feedback
I reflowed the comments to have a max width of 80 on some files, so there were a flurry of line changes, but the only substantive changes were around Joe's comments.
* Update R/input-slider.R
Co-Authored-By: Hadley Wickham <h.wickham@gmail.com >
* Apply suggestions from code review
Co-Authored-By: Carson Sievert <cpsievert1@gmail.com >
* PR feedback, regenerate docs.
* PR Feedback
* Eliminate extra newline
* passwordInput()'s server value
* varSelectInput()'s server value
* document
2019-09-12 20:02:44 +00:00
Winston Chang
7f3a45fb5b
Merge pull request #2560 from rstudio/barret-reactlog-keybindings
...
Use ctrl/cmd + shift + f3 to mark reactlog and Return a 501 error code if reactlog disabled
2019-09-12 10:29:57 -05:00
Barret Schloerke
b0953e810b
merge master
2019-09-12 10:26:38 -04:00
Hadley Wickham
52a86012e5
Update R/notifications.R
...
Co-Authored-By: Carson Sievert <cpsievert1@gmail.com >
2019-09-12 09:09:09 -05:00
Hadley Wickham
2a06fe6baf
Clarify use of id argument
2019-09-12 08:28:27 -05:00
Carson
6e688d2175
add fillPage() to the family as well
2019-09-11 16:30:25 -05:00
Carson
b610fd1f56
Hadley's feedback
2019-09-11 16:29:48 -05:00
Carson
a4730096f4
code review
2019-09-11 15:23:41 -05:00
leslie-huang
6a02439944
add @ family to all layout functions
2019-09-11 15:15:38 -05:00
Carson Sievert
b889b0d2b0
Merge pull request #2582 from rstudio/barret_showcase_hidden_wide
...
Fix showcase bug where hidden by default on wide window
2019-09-11 10:59:18 -07:00
Carson
ba5733e4a4
add news item
2019-09-11 12:34:20 -05:00
Carson Sievert
2e0221ecfd
Merge pull request #2592 from rstudio/set-min-max
...
Exit early if date parsing fails
2019-09-09 13:55:08 -07:00
Carson
aeded79544
yarn build
2019-09-09 15:43:41 -05:00
Carson
c0a7958e77
update news
2019-09-09 15:18:41 -05:00
Carson
431b194ec2
Exit early if date parsing fails in _setMin() and _setMax(), closes #2591
2019-09-09 13:48:18 -05:00
Joe Cheng
29d24d7e08
Merge pull request #2586 from rstudio/resourcePathChangesOption
...
Suppress resource path changes by default
2019-09-06 13:20:35 -07:00
Winston Chang
3b04c642ae
Bump httpuv version dependency
2019-09-06 11:47:58 -05:00
Winston Chang
609fc5b0c0
Fix typo
2019-09-06 11:46:58 -05:00
Winston Chang
2a8c79b577
Merge pull request #2588 from rstudio/wch-slider-phantom
...
Add try-catch to ion.rangeSlider
2019-09-06 10:52:25 -05:00
Winston Chang
043316e40f
Clarify comments
2019-09-06 10:52:08 -05:00
Joe Cheng
c9d8b987d4
Merge pull request #2522 from rstudio/wch-fix-reactivepoll-leak
...
Fix reactivePoll leak
2019-09-05 16:44:57 -07:00
Joe Cheng
33c5a5c665
Fix unit test
2019-09-05 16:12:07 -07:00
Winston Chang
29c90ba163
Code review fixes
2019-09-05 16:12:07 -07:00
Winston Chang
8c19450b10
Use safer method to remove observer
2019-09-05 16:11:47 -07:00
Winston Chang
89c97458c4
Update NEWS
2019-09-05 16:11:47 -07:00
Winston Chang
02be516902
Use safer finalizer for reactivePoll
2019-09-05 16:11:47 -07:00
Winston Chang
47ada300ea
Fix reactivePoll leak
2019-09-05 16:11:19 -07:00
Carson
6f9c621774
Always suppress for now
2019-09-05 17:22:56 -05:00
Winston Chang
0310fe3b68
Automate patches for ion.rangeSlider
2019-09-05 16:00:56 -05:00
Winston Chang
7144a6e4b7
In ion.rangeSlider, wrap removeProp() in try-catch. Closes #2587
2019-09-05 15:53:37 -05:00
Carson
1c8071a96f
Add shiny.resourcePathChanges option to get more information about resource path changes for a given prefix.
...
Closes #2584
2019-09-05 13:44:21 -05:00
Carson Sievert
ff5377da9e
Merge pull request #2583 from rstudio/carson_resource_warning
...
Fix spacing in warning for resource paths conflicting with www/ subdirs
2019-09-04 11:27:09 -07:00
Carson
7aee84eb05
Fix spacing in warning for resource paths conflicting with www/ subdirs
2019-09-04 11:52:31 -05:00
Barret Schloerke
c0a7a6d0d6
don't hide the current element, instead make sure new element is hidden before fading in
2019-09-04 12:44:08 -04:00
Barret Schloerke
29c48471f2
hide the prior element, not the new element
2019-09-04 12:24:49 -04:00
Barret Schloerke
229e56464b
if no code tab exists, do not attempt to highlight it
2019-09-04 12:24:20 -04:00
Joe Cheng
769c32fd38
Merge pull request #2580 from hadley/shinyApp-docs
...
shinyApp() documentation improvements.
2019-09-04 08:12:17 -07:00
Joe Cheng
d05b89cfb3
Merge pull request #2581 from hadley/shinyApp-args
...
Clarify required argumented to shinyApp()
2019-09-04 08:08:44 -07:00
Hadley Wickham
f1f18a2334
Clarify required argumented to shinyApp()
...
This does technically change the interface as `shinyApp(server = function(input, output) ...))` would have previously worked, but it didn't generate a useful app.
Fixes #2462
2019-09-04 09:57:19 -05:00
Hadley Wickham
afc556f801
More details about server argument
...
Fixes #2508
2019-09-04 09:46:57 -05:00
Hadley Wickham
7f240839fc
Document shiny.appobj in own file
...
Fixes #2458
2019-09-04 09:44:48 -05:00
Joe Cheng
8d0a6274cb
Merge pull request #2579 from rstudio/wch-fix-sleep
...
Remove Sys.sleep in runApp()
2019-09-03 14:11:29 -07:00
Winston Chang
91cab10ff8
Remove Sys.sleep in runApp()
2019-09-03 15:09:51 -05:00
Joe Cheng
5828ea7426
Merge pull request #2577 from hadley/print-methods
...
Implement two missing print methods
2019-09-03 08:14:51 -07:00
Joe Cheng
80ba147168
Merge pull request #2566 from rstudio/fix-statichandler-backslash
...
Disallow backslash in staticHandler paths
2019-09-03 07:50:35 -07:00