Carson
aa0c841aff
Close #3244 : sliderInput()'s handles are now always round
2021-01-08 14:22:14 -06:00
Carson
a8449382f0
Start shiny v1.6 release candidate
2021-01-05 13:52:16 -06:00
Carson Sievert
5b27d9258e
Don't change the return value of bootstrapPage() if bslib isn't relevant ( #3236 )
...
* Close #3235 : Don't change the return value of bootstrapPage() if bslib isn't relevant
Also, improved error message if theme is a character vector with 2 or more elements
* yarn build (GitHub Actions)
* bump version
* yarn build (GitHub Actions)
* Don't add an additional level to the returned tree structure
* More straightforward use of do.call()
Co-authored-by: cpsievert <cpsievert@users.noreply.github.com >
Co-authored-by: Winston Chang <winston@stdout.org >
2021-01-05 13:21:38 -06:00
Winston Chang
2590cf3895
Drop GHA pr-commands and add GHA Rituals. Use pak to install ( #3230 )
...
Co-authored-by: Winston Chang <winston@stdout.org >
Co-authored-by: Barret Schloerke <schloerke@gmail.com >
2020-12-28 13:28:38 -05:00
Nick Strayer
a9f7068b2f
bindCache() docs typos ( #3232 )
...
* vert -> very
* cachem::cache_mem() uses max_size argument to set size.
* Rebuilt docs after cache typo fixes
* Rerender docs with new roxygen version
* Installed cairo and rebuilt docs
2020-12-23 17:14:57 -06:00
Carson Sievert
1f9e4929a6
Follow up to #3228 . shinyAppDir() now throws a classed condition when appDir is not a directory ( #3229 )
2020-12-23 10:20:48 -06:00
Carson Sievert
d56afca33e
shinyAppDir() now throws an exception with a special class if no app.R/server.R file is found. ( #3228 )
...
shinytest:::is_app() can make use of this for better error reporting
2020-12-22 10:41:55 -06:00
Carson Sievert
8fa023b4ec
Closes #223 : Add selectize patch file to capture changes from #3217 ( #3227 )
2020-12-21 11:06:35 -06:00
Winston Chang
d9f73c4c6d
Merge pull request #3212 from rstudio/wch-fix-selectize-enter
2020-12-21 10:42:55 -06:00
Winston Chang
68cf1c5410
Check for empty list
2020-12-21 10:40:24 -06:00
Winston Chang
a70220c6c4
Rebuild JS file
2020-12-19 23:02:20 -06:00
Winston Chang
99207d1d8f
Simplify handling of empty options
2020-12-19 23:02:20 -06:00
Winston Chang
0baf2ecd70
Apply patches
2020-12-19 23:02:20 -06:00
Winston Chang
2c6f830223
Add patch for not triggering click on selectize
2020-12-19 23:02:20 -06:00
Winston Chang
98eb1b596d
Update selectize-plugin-a11y comments
2020-12-19 23:02:20 -06:00
Winston Chang
145d222653
Add webdriver to remotes
2020-12-19 22:57:46 -06:00
Winston Chang
67e54572a8
Rebuild JS files
2020-12-19 22:52:01 -06:00
Winston Chang
3cc9b33a8d
yarn upgrade
2020-12-19 22:51:24 -06:00
Barret Schloerke
12bc94fbc0
bump dev version to 1.5.0.9006 ( #3221 )
2020-12-19 16:32:22 -06:00
Winston Chang
b2379bfa5b
Cache packages on Windows
2020-12-19 13:41:06 -06:00
Barret Schloerke
f4fc13fc2f
Add devmode() features ( #3174 )
...
Co-authored-by: Barret Schloerke <schloerke@gmail.com >
Co-authored-by: Winston Chang <winston@stdout.org >
2020-12-18 14:31:31 -05:00
Nick Strayer
95081c43a7
Make sure setCurrentTheme() doesn't try and change bootstrap versions ( #3210 )
...
* Added check to make sure setCurrentTheme() doesn't try and change bootstrap version
* Update R/shiny.R
Style improvements via Carson
Co-authored-by: Carson Sievert <cpsievert1@gmail.com >
* Update error message to be more specific
Co-authored-by: Carson Sievert <cpsievert1@gmail.com >
* Make it clearer where the new bs_theme() call should be made.
* Add a check to make sure setCurrentTheme() receive a bs_theme() object
Co-authored-by: Nick Strayer <nick.strayer@gmail.com >
Co-authored-by: Carson Sievert <cpsievert1@gmail.com >
2020-12-18 13:28:16 -06:00
Winston Chang
bb3b3d5a47
Use rlang from CRAN
2020-12-18 12:39:29 -06:00
Carson Sievert
f635f98ccb
Put pre-Chromium Edge in the same category as IE ( #3220 )
...
* Put pre-Chromium Edge in the same category as IE, closes #3219
* code review
2020-12-18 12:08:50 -06:00
Carson Sievert
eef44295db
Close #3215 , selectize's active item fg color now uses bslib's color-contrast() for more generalized contrasting ( #3217 )
2020-12-18 12:01:44 -06:00
Barret Schloerke
5e1afc61c1
Update private$currentThemeDependency label to be Theme Counter ( #3206 )
...
* Update `private$currentThemeDependency` label to be `Theme Iteration`
* Update R/shiny.R
Co-authored-by: Winston Chang <winston@stdout.org >
2020-12-16 15:31:50 -06:00
Carson Sievert
8edcbb3dc1
Revert "Make .shiny-text-output more aware of Bootstrap's pre styles ( #3203 )" ( #3209 )
...
This reverts commit 4eeb4a12a7 .
This change was superfluous given that bslib's bs3compat CSS will provide <pre> styles and reduces the risk of overriding user rules targetting .shiny-text-output (https://github.com/rstudio/shinycoreci-apps/issues/95 )
2020-12-16 13:41:01 -06:00
Malcolm Barrett
dca3722cb8
fix typo in docs ( #3204 )
...
Co-authored-by: runner <runner@Mac-1607960235106.local >
2020-12-16 13:37:16 -06:00
Stéphane Guillou
7eb0e93731
typos in documentation ( #3205 )
...
Co-authored-by: runner <runner@Mac-1607961254343.local >
2020-12-16 13:36:32 -06:00
Carson Sievert
6034c3ff7a
Resend CSS styles when relevant element(s) mutate. ( #3198 )
2020-12-16 11:59:37 -06:00
Carson Sievert
4eeb4a12a7
Make .shiny-text-output more aware of Bootstrap's pre styles ( #3203 )
2020-12-11 18:55:27 -06:00
Winston Chang
6daa689888
Merge pull request #3201 from rstudio/wch-fix-datepicker
2020-12-11 15:51:46 -06:00
Winston Chang
cded44b40a
Update NEWS
2020-12-11 15:51:08 -06:00
Winston Chang
290c9f6b20
Rebuild JS files
2020-12-11 15:51:08 -06:00
Winston Chang
be3d712fdf
Set min/max date before setting value. Closes #3197
2020-12-11 15:51:08 -06:00
Winston Chang
f5666bcba1
Respect shiny.minified for bootstrap-datepicker.js
2020-12-11 10:02:01 -06:00
Winston Chang
f3c89bed01
Merge pull request #3199 from rstudio/fix-session-validate
...
Co-authored-by: Carson <cpsievert1@gmail.com >
2020-12-10 18:06:12 -06:00
Carson
9b0f170730
Skip POSIXlt slider tests on R3.6 and below
2020-12-10 15:24:07 -06:00
Winston Chang
74350cd443
Update NEWS
2020-12-10 12:28:46 -06:00
Winston Chang
61aa7bb3b0
validate_session_object: Also work with modules
2020-12-10 12:25:30 -06:00
Winston Chang
82fdbeda49
Fix test
2020-12-10 12:25:12 -06:00
Winston Chang
196b220faf
All session parameters from the update* functions now default to getDefaultReactiveDomain() ( #3195 )
...
Co-authored-by: colin <colin@thinkr.fr >
2020-12-08 12:18:37 -06:00
Hadley Wickham
f41c484913
Respect reactiveConsole() in new errors ( #3193 )
2020-12-08 12:17:43 -06:00
Carson Sievert
a1a20b3f4b
Add NEWS notes for #3042 and #3038 ( #3191 )
...
Co-authored-by: Winston Chang <winston@stdout.org >
2020-12-08 10:59:23 -06:00
Winston Chang
bbf9bee28e
Add a warning message when value < min | value > max in sliderInput ( #3194 )
...
Co-authored-by: Carson Sievert <cpsievert1@gmail.com >
Co-authored-by: colin <colin@thinkr.fr >
Co-authored-by: Colin Fay <contact@colinfay.me >
2020-12-08 10:55:18 -06:00
Winston Chang
24a1ef9594
Clear selected date if not within min/max range ( #3188 )
2020-12-07 09:13:48 -06:00
Carson Sievert
c5adef0a05
Add 'auto' brush fill and stroke ( #2864 )
...
* Add 'auto' brush fill and stroke
* getStyle() from utils
* Update getThematicOption()
* Use getThematicOption() helper in startPNG(), too
2020-12-04 16:49:08 -06:00
Carson Sievert
508c197446
getCurrentOutputInfo() bugfix ( #3189 )
2020-12-04 16:38:48 -06:00
Carson Sievert
473ec834fe
radioButtons() and checkboxGroup() accessibility ( #3187 )
...
Co-authored-by: Carson Sievert <cpsievert1@gmail.com >
Co-authored-by: JooYoung Seo <sjysky@gmail.com >
2020-12-04 15:53:53 -06:00
Carson Sievert
66968904bf
Cleaner logic for conditional CSS styles ( #2671 )
...
* Cleaner logic for conditional CSS styles
It's really only plotOutput() that behaves differently;
previously it was not possible to specify a NULL width
or height and not get broken styles
* require dev version of htmltools
Co-authored-by: Joe Cheng <joe@rstudio.com >
2020-12-04 15:52:50 -06:00