Barret Schloerke
bf8dbc38c7
add a noReactId label and init rLog method
2018-12-13 13:25:53 -05:00
Barret Schloerke
ae0d4d9353
add a default reactId for contexts for clearer msg logs and rLogs
2018-12-13 10:48:32 -05:00
Barret Schloerke
43ec4ae238
add helper functions for msg logger.
2018-12-13 10:48:02 -05:00
Barret Schloerke
c568a8cabe
when updating a value for reactVal or a reactValues key, the context should not be recorded
2018-12-13 10:46:12 -05:00
Barret Schloerke
423bdd8b6b
read reactlog version from description file
2018-12-12 11:27:17 -05:00
Barret Schloerke
1e19ff65e6
fix bad comma usage
2018-12-12 11:04:36 -05:00
Barret Schloerke
a9cf632f53
markTime -> userMark; queueEmpty -> idle
2018-12-12 10:58:28 -05:00
Barret Schloerke
fddf94a341
this check is already covered
2018-12-11 17:23:22 -05:00
Barret Schloerke
203168d261
dec/increment with integers
2018-12-11 17:23:13 -05:00
Barret Schloerke
0e3c3536f8
no need to store messages
2018-12-11 17:22:59 -05:00
Barret Schloerke
45b2b7e24f
use curly brackets for all function defs
2018-12-11 17:22:33 -05:00
Barret Schloerke
88f177b065
use class brackets for R6 def
2018-12-11 17:22:09 -05:00
Barret Schloerke
ea7a8dd3ad
consistent naming
2018-12-11 17:14:30 -05:00
Barret Schloerke
dda8f92494
remove writeReactLog
2018-12-11 17:13:09 -05:00
Barret Schloerke
26211802cd
spelling and comments
2018-12-11 17:12:59 -05:00
Barret Schloerke
b4bef0d32c
use reactlog::reactlog_add_shiny_resource_paths
2018-12-11 17:12:38 -05:00
Barret Schloerke
26a136a6e8
check_suggested now takes a github location and a source install script
2018-12-04 14:38:14 -05:00
Barret Schloerke
f24c12fdfb
shinyreactlog -> reactlog
2018-11-30 16:02:00 -05:00
Barret Schloerke
9a345d191b
merge in master
2018-11-27 10:33:11 -05:00
Winston Chang
6a373b585c
Merge pull request #2248 from rstudio/fix-selectize-label
...
Make updateSelectizeInput() work with labels again
2018-11-15 17:04:16 -06:00
Winston Chang
54480e2510
Merge branch 'master' into fix-selectize-label
2018-11-15 17:03:58 -06:00
Joe Cheng
83f73603db
Merge pull request #2257 from colearendt/fix-htmltools-dep
...
fix dependency version since htmltools 0.3.6 is used
2018-11-15 14:39:37 -08:00
Joe Cheng
2b10f192ba
Merge pull request #2261 from rstudio/joe/bugfix/async-rendercachedplot
...
Fix #2247 : Async cached plots raise "Error in !: invalid argument type" error
2018-11-15 14:39:07 -08:00
Winston Chang
775d5289cb
Grunt
2018-11-15 15:23:35 -06:00
Winston Chang
e6c66352a7
Update NEWS
2018-11-15 15:23:35 -06:00
Winston Chang
77afd73ee1
Use new selectize suffix. Fixes #2245
2018-11-15 15:23:35 -06:00
Winston Chang
5ac96a40aa
Remove QuitChildProcessesOnExit: Default option
2018-11-15 15:10:54 -06:00
Winston Chang
2fea0e2598
Don't byte-compile when doing local install in RStudio
2018-11-15 15:08:49 -06:00
Joe Cheng
2b64949cbe
Fix #2247 : Async cached plots raise "Error in !: invalid argument type" error
2018-11-14 16:45:40 -08:00
Cole Arendt
918d57f25e
fix dependency version since htmltools 0.3.6 is used
2018-11-11 15:04:44 -05:00
Joe Cheng
5e2b40d3a9
Bump version for development
2018-11-02 13:11:04 -07:00
Joe Cheng
979ef4bd43
Merge remote-tracking branch 'origin/v1.2-rc'
2018-11-02 13:10:48 -07:00
Winston Chang
914baf594b
Merge pull request #2241 from rstudio/joe/bugfix/icon-examples
...
Remove icon examples
2018-11-01 20:41:58 -05:00
Joe Cheng
02b0802886
Add note about FontAwesome path change
2018-11-01 15:08:59 -07:00
Joe Cheng
0725239397
Remove icon examples
...
These cause browser windows to pop up during R CMD check, which is
against CRAN policy. @wch will merge a PR that has other examples
once we release v1.2.
2018-11-01 14:56:15 -07:00
Joe Cheng
d72e8a06a7
Fix error in global reactiveTimer
...
When reactiveTimer is created without a default reactive domain
(i.e. outside of a session, i.e. global) there's no session to
call cycleStartAction on. Instead, invalidation should proceed
right away.
Fixes #2228
2018-10-29 11:43:03 -05:00
Joe Cheng
cf79fec720
Merge pull request #2226 from rstudio/joe/bugfix/cycle-queue-stall-2
...
Fix input event queue stall
2018-10-25 15:19:23 -07:00
Joe Cheng
31dda45d1c
Update NEWS
2018-10-25 12:13:37 -07:00
Joe Cheng
9836b72661
Fix #2225 : Input event queue can stall in apps that use async
2018-10-25 12:12:21 -07:00
Winston Chang
6ede0194c6
Update license information in README
2018-10-25 12:15:57 -05:00
Winston Chang
5ec38581ca
Add support for Font-Awesome 5 brands ( #2221 )
...
* Add support for Font-Awesome 5 brands
* Fix glyphicon support
2018-10-24 16:13:36 -05:00
Winston Chang
2629e59ace
Re-document
2018-10-18 22:52:43 -05:00
Alan Dipert
f3eb770e20
Add to fontawesome news entry ( #2214 )
...
* Add FontAwesome upgrade information to NEWS.md
* Update NEWS.md
* Update NEWS.md
2018-10-18 11:57:29 -05:00
Winston Chang
0683b79fac
Fix datepicker DST bug ( #2212 )
...
* Fix datepicker DST bug. Closes #2204
This fix is borrowed from:
13885397de (diff-dd513a8bab7ad1033c8784c4a1b9ce15)
2018-10-17 15:01:39 -05:00
Alan Dipert
fcd09e2bae
Simplify DnD for fileInputs, fix #2142 (Firefox 57+)
...
- Simplified dragHover "plugin" by counting children instead of storing them.
Counting children fixes Firefox 57+ bug (to be found or filed) that causes
text object of input element to produce drag events
- Removed multimethod since it's no longer used anywhere
- Firefox 57+ appears not to trigger a change event when the `files` field is modified,
which prevented uploads from occuring. This commit triggers a change event manually
and doesn't impact the functioning of other browsers.
2018-10-08 21:24:18 -07:00
Joe Cheng
b25cb0f2d5
Merge pull request #2200 from rstudio/joe/bugfix/brush-webkit
...
Fix brushes not being properly cleared
2018-09-27 14:23:27 -07:00
Barret Schloerke
0704aec01b
Follow js event namespacing conventions and only possibly init brush once ( #2202 )
...
* underscore the shiny_image_interaction namespace
* namespace dragstart
* use `one` instead of `on`
* compile
2018-09-27 16:24:53 -04:00
Barret Schloerke
d38b939c63
use naturalHeight and naturalWidth for default dim values. Followup comments from winston ( #2201 )
2018-09-27 16:16:11 -04:00
Joe Cheng
112466de1e
Fix brushes not being properly cleared
...
Actually three separate issues addressed. Fixes #2197 .
- brush.importOldBrush() was not being called anymore, due to it being
registered as a load handler after the image was already loaded (this
was a very recent regression, less than 24 hours old).
- Each time the brush changes, the plot is redrawn twice. This was
because importing the old brush introduced floating point errors that
led to a slightly different new brush being created.
- Sometimes the image's load event wasn't firing at all. This is due to
behavior in WebKit where assigning an image's src to its existing
value is a no-op.
2018-09-26 22:57:16 -07:00
Barret Schloerke
1d0edd2ad0
Initialize brush dims for renderImage objects ( #2198 )
...
* wait for image to be loaded in browser before initializing handlers
reverts similar behavior in 3354a47e8a
2018-09-26 13:29:42 -04:00
