Compare commits

...

7 Commits

Author SHA1 Message Date
Winston Chang
00775b90e8 Bump version to 1.7.1 2021-09-30 14:48:12 -05:00
Winston Chang
c6ae4c0034 Update NEWS 2021-09-30 14:48:06 -05:00
Winston Chang
1efcaa0b5d Use esbuild option preserveSymlinks
This allows the node_modules directory to be a symlink, without causing weird
build problems.
2021-09-30 14:44:17 -05:00
Carson Sievert
e6d94f6f66 Fix regression in repeated appendTab()s when navbarMenu() is present (#3518) 2021-09-30 14:43:09 -05:00
Barret Schloerke
5a8a02626c add news item for #3512 2021-09-28 18:00:36 -04:00
Hadley Wickham
c23293750d Re-arrange conditions for testthat 1.0.0 compatibility (#3512) 2021-09-28 17:51:45 -04:00
Winston Chang
9de74048a2 Bump version to 1.7.0.9000 2021-09-28 16:39:35 -05:00
9 changed files with 35 additions and 31 deletions

View File

@@ -1,7 +1,7 @@
Package: shiny
Type: Package
Title: Web Application Framework for R
Version: 1.7.0
Version: 1.7.1
Authors@R: c(
person("Winston", "Chang", role = c("aut", "cre"), email = "winston@rstudio.com", comment = c(ORCID = "0000-0002-1576-2126")),
person("Joe", "Cheng", role = "aut", email = "joe@rstudio.com"),

12
NEWS.md
View File

@@ -1,5 +1,15 @@
shiny 1.7.1
===========
## Bug Fixes
* Closed #3516: Fix regression in repeated calls to `appendTab()` when `navbarMenu()` is already present within a `tabsetPanel()`/`navbarPage()`. (#3518)
* Re-arranged conditions for testthat 1.0.0 compatibility. (#3512)
shiny 1.7.0
================
===========
## Full changelog

View File

@@ -12818,8 +12818,8 @@
}
function getTabIndex($tabset2, tabsetId2) {
var existingTabIds = [0];
$tabset2.find("a[data-toggle='tab']").each(function() {
var $tab = (0, import_jquery41.default)(this);
$tabset2.find("> li").each(function() {
var $tab = (0, import_jquery41.default)(this).find("> a[data-toggle='tab']");
if ($tab.length > 0) {
var href = $tab.attr("href").replace(/.*(?=#[^\s]+$)/, "");
var _index = href.replace("#tab-" + tabsetId2 + "-", "");

File diff suppressed because one or more lines are too long

File diff suppressed because one or more lines are too long

File diff suppressed because one or more lines are too long

View File

@@ -70,6 +70,7 @@ async function build(
incremental: incremental,
watch: watch,
target: "es5",
preserveSymlinks: true,
...opts,
}).then((x) => {
onRebuild();

View File

@@ -1112,8 +1112,8 @@ class ShinyApp {
// loop through all existing tabs, find the one with highest id
// (since this is based on a numeric counter), and increment
$tabset.find("a[data-toggle='tab']").each(function () {
const $tab = $(this);
$tabset.find("> li").each(function () {
const $tab = $(this).find("> a[data-toggle='tab']");
if ($tab.length > 0) {
// remove leading url if it exists. (copy of bootstrap url stripper)

View File

@@ -216,28 +216,21 @@ test_that("dateYMD works", {
c("2020-01-14", "2019-11-05")
)
expect_identical(
expect_warning(dateYMD("")),
""
)
expect_identical(
expect_warning(dateYMD(c(NA))),
NA
)
expect_identical(
expect_warning(dateYMD(c("", NA))),
c("", NA)
)
expect_warning(val <- dateYMD(""))
expect_identical(val, "")
expect_warning(val <- dateYMD(c(NA)))
expect_identical(val, NA)
expect_warning(val <- dateYMD(c("", NA)))
expect_identical(val, c("", NA))
# If there are any bad values, the entire thing goes through unchanged
expect_identical(
expect_warning(dateYMD(c("2019/11/05", NA))),
c("2019/11/05", NA)
)
expect_identical(
expect_warning(dateYMD(c("2019/11/05", ""))),
c("2019/11/05", "")
)
expect_warning(val <- dateYMD(c("2019/11/05", NA)))
expect_identical(val, c("2019/11/05", NA))
expect_warning(val <- dateYMD(c("2019/11/05", "")))
expect_identical(val, c("2019/11/05", ""))
})
test_that("quoToFunction handles nested quosures", {