mirror of
https://github.com/rstudio/shiny.git
synced 2026-02-08 21:55:02 -05:00
908d635063
* All of these were caused by the presence of multiple body tags on the page, which happened because networkD3's sankey plot generates SVGs containing body tags via SVG's foreignObject tag * In various places, the 'body' jQuery selector string is used under the assumption there is only one 'body' tag on the page. The presence of multiple 'body' tags breaks reliant code in strange ways. * The fix was to use document.body or 'body:first' instead of 'body'.
67 lines
2.3 KiB
JavaScript
67 lines
2.3 KiB
JavaScript
exports.modal = {
|
|
|
|
// Show a modal dialog. This is meant to handle two types of cases: one is
|
|
// that the content is a Bootstrap modal dialog, and the other is that the
|
|
// content is non-Bootstrap. Bootstrap modals require some special handling,
|
|
// which is coded in here.
|
|
show: function({ html='', deps=[] } = {}) {
|
|
|
|
// If there was an existing Bootstrap modal, then there will be a modal-
|
|
// backdrop div that was added outside of the modal wrapper, and it must be
|
|
// removed; otherwise there can be multiple of these divs.
|
|
$('.modal-backdrop').remove();
|
|
|
|
// Get existing wrapper DOM element, or create if needed.
|
|
let $modal = $('#shiny-modal-wrapper');
|
|
if ($modal.length === 0) {
|
|
$modal = $('<div id="shiny-modal-wrapper"></div>');
|
|
$(document.body).append($modal);
|
|
|
|
// If the wrapper's content is a Bootstrap modal, then when the inner
|
|
// modal is hidden, remove the entire thing, including wrapper.
|
|
$modal.on('hidden.bs.modal', function(e) {
|
|
if (e.target === $("#shiny-modal")[0]) {
|
|
exports.unbindAll($modal);
|
|
$modal.remove();
|
|
}
|
|
});
|
|
}
|
|
|
|
$modal.on('keydown.shinymodal', function(e) {
|
|
// If we're listening for Esc, don't let the event propagate. See
|
|
// https://github.com/rstudio/shiny/issues/1453. The value of
|
|
// data("keyboard") needs to be checked inside the handler, because at
|
|
// the time that $modal.on() is called, the $("#shiny-modal") div doesn't
|
|
// yet exist.
|
|
if ($("#shiny-modal").data("keyboard") === false)
|
|
return;
|
|
|
|
if (e.keyCode === 27) {
|
|
e.stopPropagation();
|
|
e.preventDefault();
|
|
}
|
|
});
|
|
|
|
// Set/replace contents of wrapper with html.
|
|
exports.renderContent($modal, { html: html, deps: deps });
|
|
},
|
|
|
|
remove: function() {
|
|
const $modal = $('#shiny-modal-wrapper');
|
|
|
|
$modal.off('keydown.shinymodal');
|
|
|
|
// Look for a Bootstrap modal and if present, trigger hide event. This will
|
|
// trigger the hidden.bs.modal callback that we set in show(), which unbinds
|
|
// and removes the element.
|
|
if ($modal.find('.modal').length > 0) {
|
|
$modal.find('.modal').modal('hide');
|
|
|
|
} else {
|
|
// If not a Bootstrap modal dialog, simply unbind and remove it.
|
|
exports.unbindAll($modal);
|
|
$modal.remove();
|
|
}
|
|
}
|
|
};
|