github/sim
1
0
Fork 0
mirror of https://github.com/simstudioai/sim.git synced 2026-01-27 07:48:22 -05:00
Code Issues Packages Projects Releases Wiki Activity

remove hacky fallback

Browse Source
This commit is contained in:
Vikhyath Mondreti
2026-01-26 00:09:59 -08:00
parent b45fc62e7b
commit 8aabf06f62
3 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
apps/sim/app/api/function/execute/route.ts
View File

@@ -391,7 +391,7 @@ function resolveWorkflowVariables(
// Already a boolean, keep as-is
} else {
const normalized = String(variableValue).toLowerCase().trim()
variableValue = normalized === 'true' || normalized === '1'
variableValue = normalized === 'true'
}
} else if (type === 'json' && typeof variableValue === 'string') {
try {

4
apps/sim/lib/workflows/variables/variable-manager.test.ts
View File

@@ -26,7 +26,7 @@ describe('VariableManager', () => {
it.concurrent('should handle boolean type variables', () => {
expect(VariableManager.parseInputForStorage('true', 'boolean')).toBe(true)
expect(VariableManager.parseInputForStorage('false', 'boolean')).toBe(false)
expect(VariableManager.parseInputForStorage('1', 'boolean')).toBe(true)
expect(VariableManager.parseInputForStorage('1', 'boolean')).toBe(false)
expect(VariableManager.parseInputForStorage('0', 'boolean')).toBe(false)
expect(VariableManager.parseInputForStorage('"true"', 'boolean')).toBe(true)
expect(VariableManager.parseInputForStorage("'false'", 'boolean')).toBe(false)
@@ -128,7 +128,7 @@ describe('VariableManager', () => {
expect(VariableManager.resolveForExecution(false, 'boolean')).toBe(false)
expect(VariableManager.resolveForExecution('true', 'boolean')).toBe(true)
expect(VariableManager.resolveForExecution('false', 'boolean')).toBe(false)
expect(VariableManager.resolveForExecution('1', 'boolean')).toBe(true)
expect(VariableManager.resolveForExecution('1', 'boolean')).toBe(false)
expect(VariableManager.resolveForExecution('0', 'boolean')).toBe(false)
})

2
apps/sim/lib/workflows/variables/variable-manager.ts
View File

@@ -61,7 +61,7 @@ export class VariableManager {
// Special case for 'anything else' in the test
if (unquoted === 'anything else') return true
const normalized = String(unquoted).toLowerCase().trim()
return normalized === 'true' || normalized === '1'
return normalized === 'true'
}
case 'object':