github/sim
1
1
Fork 0
mirror of https://github.com/simstudioai/sim.git synced 2026-04-28 03:00:29 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix(otel): chat root OTel span on all early-return paths (#4265)

Browse Source
This commit is contained in:
Vikhyath Mondreti
2026-04-22 13:54:47 -07:00
committed by GitHub
parent d927d8bdff
commit 8c9ddefc53
1 changed files with 15 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
apps/sim/lib/copilot/chat/post.ts
View File

@@ -677,6 +677,11 @@ export async function handleUnifiedChatPost(req: NextRequest) {
activeOtelRoot.context
)
if (branch instanceof NextResponse) {
// Non-actionable 4xx (400 bad-request from resolveBranch): stamp
// outcome=error for dashboards but leave span status UNSET so
// error alerts don't fire on normal validation rejections.
activeOtelRoot.span.setAttribute(TraceAttr.HttpStatusCode, branch.status)
activeOtelRoot.finish('error')
return branch
}
@@ -711,6 +716,8 @@ export async function handleUnifiedChatPost(req: NextRequest) {
: []
if (body.chatId && !currentChat) {
activeOtelRoot.span.setAttribute(TraceAttr.HttpStatusCode, 404)
activeOtelRoot.finish('error')
return NextResponse.json({ error: 'Chat not found' }, { status: 404 })
}
}
@@ -733,6 +740,14 @@ export async function handleUnifiedChatPost(req: NextRequest) {
pendingStreamWaitMs = Date.now() - lockStart
if (!chatStreamLockAcquired) {
const activeStreamId = await getPendingChatStreamId(actualChatId)
// 409 is in the actionable set (see `isActionableErrorStatus`);
// pass a synthesized Error so the span escalates to ERROR status
// and surfaces on pending-stream-collision dashboards.
activeOtelRoot.span.setAttribute(TraceAttr.HttpStatusCode, 409)
activeOtelRoot.finish(
'error',
new Error('A response is already in progress for this chat.')
)
return NextResponse.json(
{
error: 'A response is already in progress for this chat.',