github/sim
1
0
Fork 0
mirror of https://github.com/simstudioai/sim.git synced 2026-01-09 23:17:59 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix(kb): kb-level deletion should reflect in doc level kb tags sidebar registry (#944)

Browse Source
This commit is contained in:
Waleed Latif
2025-08-12 09:26:28 -07:00
committed by GitHub
parent 1c3e923f1b
commit a2dea384a4
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/knowledge-tags/knowledge-tags.tsx
View File

@@ -89,13 +89,12 @@ export function KnowledgeTags({ knowledgeBaseId, documentId }: KnowledgeTagsProp
const definition = definitions.find((def) => def.tagSlot === slot)
const currentTag = currentTags?.find((tag) => tag.slot === slot)
// Only include tag if the document actually has a value for it
if (value?.trim()) {
// Only include tag if the document has a value AND a corresponding KB tag definition exists
if (value?.trim() && definition) {
tags.push({
slot,
// Preserve existing displayName if definition is not found yet
displayName: definition?.displayName || currentTag?.displayName || '',
fieldType: definition?.fieldType || currentTag?.fieldType || 'text',
displayName: definition.displayName,
fieldType: definition.fieldType,
value: value.trim(),
})
}