github/sim
1
1
Fork 0
mirror of https://github.com/simstudioai/sim.git synced 2026-04-28 03:00:29 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix(triggers): resolve type field collision in Notion trigger outputs

Browse Source 
Rename nested `type` fields to `entity_type`/`parent_type` to avoid
collision with processOutputField's leaf node detection which checks
`'type' in field`. Remove spread of author outputs into `authors`
array which was overwriting `type: 'array'`.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Waleed Latif
2026-04-06 11:26:51 -07:00
parent 51236f03ff
commit a4eef8b1be
1 changed files with 5 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
apps/sim/triggers/notion/utils.ts
View File

@@ -59,16 +59,6 @@ export function buildNotionExtraFields(triggerId: string): SubBlockConfig[] {
]
}
/**
* Shared author output schema for Notion webhook payloads.
*/
function buildAuthorOutputs(): Record<string, TriggerOutput> {
return {
id: { type: 'string', description: 'Author user ID' },
type: { type: 'string', description: 'Author type (person or bot)' },
}
}
/**
* Base webhook outputs common to all Notion triggers.
*/
@@ -94,7 +84,7 @@ function buildBaseOutputs(): Record<string, TriggerOutput> {
function buildEntityOutputs(): Record<string, TriggerOutput> {
return {
id: { type: 'string', description: 'Entity ID (page or database ID)' },
type: { type: 'string', description: 'Entity type (page or database)' },
entity_type: { type: 'string', description: 'Entity type (page or database)' },
}
}
@@ -107,13 +97,12 @@ export function buildPageEventOutputs(): Record<string, TriggerOutput> {
authors: {
type: 'array',
description: 'Array of users who triggered the event',
...buildAuthorOutputs(),
},
entity: buildEntityOutputs(),
data: {
parent: {
id: { type: 'string', description: 'Parent page or database ID' },
type: { type: 'string', description: 'Parent type (database, page, workspace)' },
parent_type: { type: 'string', description: 'Parent type (database, page, workspace)' },
},
},
}
@@ -128,13 +117,12 @@ export function buildDatabaseEventOutputs(): Record<string, TriggerOutput> {
authors: {
type: 'array',
description: 'Array of users who triggered the event',
...buildAuthorOutputs(),
},
entity: buildEntityOutputs(),
data: {
parent: {
id: { type: 'string', description: 'Parent page or workspace ID' },
type: { type: 'string', description: 'Parent type (page, workspace)' },
parent_type: { type: 'string', description: 'Parent type (page, workspace)' },
},
},
}
@@ -149,16 +137,15 @@ export function buildCommentEventOutputs(): Record<string, TriggerOutput> {
authors: {
type: 'array',
description: 'Array of users who triggered the event',
...buildAuthorOutputs(),
},
entity: {
id: { type: 'string', description: 'Comment ID' },
type: { type: 'string', description: 'Entity type (comment)' },
entity_type: { type: 'string', description: 'Entity type (comment)' },
},
data: {
parent: {
id: { type: 'string', description: 'Parent page ID' },
type: { type: 'string', description: 'Parent type (page)' },
parent_type: { type: 'string', description: 'Parent type (page)' },
},
},
}
@@ -173,7 +160,6 @@ export function buildGenericWebhookOutputs(): Record<string, TriggerOutput> {
authors: {
type: 'array',
description: 'Array of users who triggered the event',
...buildAuthorOutputs(),
},
entity: buildEntityOutputs(),
data: {