github/sim
1
0
Fork 0
mirror of https://github.com/simstudioai/sim.git synced 2026-01-10 07:27:57 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix(subflow): remove all edges when removing a block from a subflow (#1003)

Browse Source
This commit is contained in:
Waleed Latif
2025-08-18 00:21:26 -07:00
committed by GitHub
parent 5c16e7d390
commit fdb8256468
1 changed files with 4 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/workflow.tsx
View File

@@ -352,26 +352,13 @@ const WorkflowContent = React.memo(() => {
// Remove parent-child relationship while preserving absolute position
updateNodeParent(blockId, null)
// Clean up any edges that now cross container boundaries for this block
const rfNodes = getNodes()
const sourceOrTargetEdges = edgesForDisplay.filter(
// Remove all edges connected to this block
const connectedEdges = edgesForDisplay.filter(
(e) => e.source === blockId || e.target === blockId
)
sourceOrTargetEdges.forEach((edge) => {
const sourceNode = rfNodes.find((n) => n.id === edge.source)
const targetNode = rfNodes.find((n) => n.id === edge.target)
const sourceParent = sourceNode?.parentId
const targetParent = targetNode?.parentId
const crossesBoundary =
(sourceParent && !targetParent) ||
(!sourceParent && targetParent) ||
(sourceParent && targetParent && sourceParent !== targetParent)
if (crossesBoundary) {
removeEdge(edge.id)
}
connectedEdges.forEach((edge) => {
removeEdge(edge.id)
})
} catch (err) {
logger.error('Failed to remove from subflow', { err })