Compare commits

...

3 Commits

Author SHA1 Message Date
Vikhyath Mondreti
7e889f5eec fix attempt 2 2026-01-13 00:04:15 -08:00
Vikhyath Mondreti
d8f3169256 fix 2026-01-12 23:54:50 -08:00
Vikhyath Mondreti
de2294f565 fix(slack): race condition in credential selection 2026-01-12 23:51:16 -08:00

View File

@@ -1,6 +1,6 @@
'use client'
import { useCallback, useEffect, useMemo, useState } from 'react'
import { useCallback, useEffect, useMemo, useRef, useState } from 'react'
import { createLogger } from '@sim/logger'
import { ExternalLink, Users } from 'lucide-react'
import { Button, Combobox } from '@/components/emcn/components'
@@ -29,6 +29,20 @@ import { useWorkflowRegistry } from '@/stores/workflows/registry/store'
const logger = createLogger('CredentialSelector')
const isBillingEnabled = isTruthy(getEnv('NEXT_PUBLIC_BILLING_ENABLED'))
function useStableCredentialIds(credentials: Array<{ id: string }>) {
const knownIdsRef = useRef<Set<string>>(new Set())
for (const cred of credentials) {
knownIdsRef.current.add(cred.id)
}
const isKnownCredentialId = useCallback((id: string): boolean => {
return knownIdsRef.current.has(id)
}, [])
return { isKnownCredentialId }
}
interface CredentialSelectorProps {
blockId: string
subBlock: SubBlockConfig
@@ -92,6 +106,8 @@ export function CredentialSelector({
refetch: refetchCredentials,
} = useOAuthCredentials(effectiveProviderId, Boolean(effectiveProviderId))
const { isKnownCredentialId } = useStableCredentialIds(credentials)
const selectedCredential = useMemo(
() => credentials.find((cred) => cred.id === selectedId),
[credentials, selectedId]
@@ -140,7 +156,8 @@ export function CredentialSelector({
!selectedCredential &&
!hasForeignMeta &&
!credentialsLoading &&
!foreignMetaLoading
!foreignMetaLoading &&
!isKnownCredentialId(selectedId)
useEffect(() => {
if (!invalidSelection) return
@@ -348,10 +365,22 @@ export function CredentialSelector({
return
}
if (isKnownCredentialId(value)) {
handleSelect(value)
return
}
setIsEditing(true)
setInputValue(value)
},
[credentials, credentialSets, handleAddCredential, handleSelect, handleCredentialSetSelect]
[
credentials,
credentialSets,
handleAddCredential,
handleSelect,
handleCredentialSetSelect,
isKnownCredentialId,
]
)
return (