github/siv
1
1
Fork 0
mirror of https://github.com/siv-org/siv.git synced 2026-05-03 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity

Begin adding /api/revert-finalized-ballot-design endpoint

Browse Source
This commit is contained in:
David Ernst
2024-09-26 23:04:01 -07:00
parent e83466636c
commit 7ea1bd1262
2 changed files with 26 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
pages/api/election/[election_id]/admin/finalize-ballot-design.ts
View File

@@ -1,8 +1,7 @@
import { firebase } from 'api/_services'
import { checkJwtOwnsElection } from 'api/validate-admin-jwt'
import { NextApiRequest, NextApiResponse } from 'next'
import { firebase } from '../../../_services'
import { checkJwtOwnsElection } from '../../../validate-admin-jwt'
export default async (req: NextApiRequest, res: NextApiResponse) => {
const { election_id } = req.query as { election_id: string }

24
pages/api/election/[election_id]/admin/revert-finalized-ballot-design.ts Normal file
View File

@@ -0,0 +1,24 @@
import { firebase } from 'api/_services'
import { checkJwtOwnsElection } from 'api/validate-admin-jwt'
import { NextApiRequest, NextApiResponse } from 'next'
export default async (req: NextApiRequest, res: NextApiResponse) => {
const { election_id } = req.query as { election_id: string }
// Confirm they're a valid admin that created this election
const jwt = await checkJwtOwnsElection(req, res, election_id)
if (!jwt.valid) return
// TODO: Confirm there are no votes cast already
// TODO: We probably want better accountability here to be extra sure election admins aren't maliciously flipping ballot designs in misleading ways. See https://github.com/siv-org/siv/issues/85
// TODO: Notify admin this feature is being used
// TODO: Store the previously- finalized version, to ensure this feature isn't being used maliciously
// Unset `ballot_design_finalized` in db
await firebase.firestore().collection('elections').doc(election_id).update({ ballot_design_finalized: false })
return res.status(201).json({ message: 'Reverted finalized ballot design' })
}