github/socket.io
1
1
Fork 0
mirror of https://github.com/socketio/socket.io.git synced 2026-01-09 15:08:12 -05:00
Code Issues Packages Projects Releases Wiki Activity

refactor: improve types

Browse Source
This commit is contained in:
Damien Arrachequesne
2024-06-18 17:37:12 +02:00
parent f521cbab6d
commit 6b9e3e458e
3 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
lib/server.ts
View File

@@ -160,7 +160,8 @@ function parseSessionId(data: string) {
export abstract class BaseServer extends EventEmitter {
public opts: ServerOptions;
protected clients: any;
// TODO for the next major release: use a Map instead
protected clients: Record<string, Socket>;
public clientsCount: number;
protected middlewares: Middleware[] = [];
@@ -590,7 +591,7 @@ export abstract class BaseServer extends EventEmitter {
debug("upgrading existing transport");
const transport = new WebTransport(session, stream, reader);
client.maybeUpgrade(transport);
client._maybeUpgrade(transport);
}
}
@@ -857,7 +858,7 @@ export class Server extends BaseServer {
const transport = this.createTransport(req._query.transport, req);
transport.perMessageDeflate = this.opts.perMessageDeflate;
client.maybeUpgrade(transport);
client._maybeUpgrade(transport);
}
} else {
const closeConnection = (errorCode, errorContext) =>

6
lib/socket.ts
View File

@@ -26,8 +26,8 @@ export class Socket extends EventEmitter {
public transport: Transport;
private server: Server;
private upgrading = false;
private upgraded = false;
/* private */ upgrading = false;
/* private */ upgraded = false;
private writeBuffer: Packet[] = [];
private packetsFn: SendCallback[] = [];
private sentCallbackFn: SendCallback[][] = [];
@@ -264,7 +264,7 @@ export class Socket extends EventEmitter {
* @param {Transport} transport
* @api private
*/
private maybeUpgrade(transport) {
/* private */ _maybeUpgrade(transport: Transport) {
debug(
'might upgrade socket transport from "%s" to "%s"',
this.transport.name,

3
lib/userver.ts
View File

@@ -137,6 +137,7 @@ export class uServer extends BaseServer {
if (req._query.sid) {
debug("setting new request for existing client");
// @ts-ignore
this.clients[req._query.sid].transport.onRequest(req);
} else {
const closeConnection = (errorCode, errorContext) =>
@@ -194,7 +195,7 @@ export class uServer extends BaseServer {
} else {
debug("upgrading existing transport");
transport = this.createTransport(req._query.transport, req);
client.maybeUpgrade(transport);
client._maybeUpgrade(transport);
}
} else {
transport = await this.handshake(