fix: allow objects with a null prototype in binary packets (#114)

This commit is contained in:
Gabba90
2022-02-17 07:18:11 +01:00
committed by GitHub
parent 8e8346b706
commit 7f6b262ac8
2 changed files with 17 additions and 2 deletions

View File

@@ -33,7 +33,7 @@ function _deconstructPacket(data, buffers) {
} else if (typeof data === "object" && !(data instanceof Date)) {
const newData = {};
for (const key in data) {
if (data.hasOwnProperty(key)) {
if (Object.prototype.hasOwnProperty.call(data, key)) {
newData[key] = _deconstructPacket(data[key], buffers);
}
}
@@ -68,7 +68,7 @@ function _reconstructPacket(data, buffers) {
}
} else if (typeof data === "object") {
for (const key in data) {
if (data.hasOwnProperty(key)) {
if (Object.prototype.hasOwnProperty.call(data, key)) {
data[key] = _reconstructPacket(data[key], buffers);
}
}

View File

@@ -14,6 +14,21 @@ describe("parser", () => {
helpers.test_bin(packet, done);
});
it("encodes an ArrayBuffer into an object with a null prototype", (done) => {
const packet = {
type: PacketType.EVENT,
data: [
"a",
Object.create(null, {
array: { value: new ArrayBuffer(2), enumerable: true },
}),
],
id: 0,
nsp: "/",
};
helpers.test_bin(packet, done);
});
it("encodes a TypedArray", (done) => {
const array = new Uint8Array(5);
for (let i = 0; i < array.length; i++) array[i] = i;