github/socket.io
1
1
Fork 0
mirror of https://github.com/socketio/socket.io.git synced 2026-01-10 07:28:06 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix(eio-client): move 'offline' event listener at the top

Browse Source 
Related: https://github.com/socketio/socket.io/issues/5125
This commit is contained in:
Damien Arrachequesne
2024-09-21 08:36:48 +02:00
parent b04fa64365
commit 8a2f5a3da0
1 changed files with 25 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
packages/engine.io-client/lib/socket.ts
View File

@@ -20,6 +20,24 @@ const withEventListeners =
typeof addEventListener === "function" &&
typeof removeEventListener === "function";
const OFFLINE_EVENT_LISTENERS = [];
if (withEventListeners) {
// within a ServiceWorker, any event handler for the 'offline' event must be added on the initial evaluation of the
// script, so we create one single event listener here which will forward the event to the socket instances
addEventListener(
"offline",
() => {
debug(
"closing %d connection(s) because the network was lost",
OFFLINE_EVENT_LISTENERS.length,
);
OFFLINE_EVENT_LISTENERS.forEach((listener) => listener());
},
false,
);
}
export interface SocketOptions {
/**
* The host that we're connecting to. Set from the URI passed when connecting
@@ -448,12 +466,13 @@ export class SocketWithoutUpgrade extends Emitter<
);
}
if (this.hostname !== "localhost") {
debug("adding listener for the 'offline' event");
this._offlineEventListener = () => {
this._onClose("transport close", {
description: "network connection lost",
});
};
addEventListener("offline", this._offlineEventListener, false);
OFFLINE_EVENT_LISTENERS.push(this._offlineEventListener);
}
}
@@ -916,7 +935,11 @@ export class SocketWithoutUpgrade extends Emitter<
);
}
if (this._offlineEventListener) {
removeEventListener("offline", this._offlineEventListener, false);
const i = OFFLINE_EVENT_LISTENERS.indexOf(this._offlineEventListener);
if (i !== -1) {
debug("removing listener for the 'offline' event");
OFFLINE_EVENT_LISTENERS.splice(i, 1);
}
}
}