github/socket.io
1
1
Fork 0
mirror of https://github.com/socketio/socket.io.git synced 2026-01-09 15:08:12 -05:00
Code Issues Packages Projects Releases Wiki Activity

refactor(sio): use URL constructor instead of url.parse()

Browse Source 
Related: https://github.com/socketio/socket.io/issues/5377
This commit is contained in:
Damien Arrachequesne
2025-12-19 14:36:22 +01:00
parent d88f3f4578
commit 8af70195bb
1 changed files with 15 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
packages/socket.io/lib/client.ts
View File

@@ -267,16 +267,7 @@ export class Client<
* @private
*/
private ondecoded(packet: Packet): void {
let namespace: string;
let authPayload: Record<string, unknown>;
if (this.conn.protocol === 3) {
const parsed = url.parse(packet.nsp, true);
namespace = parsed.pathname!;
authPayload = parsed.query;
} else {
namespace = packet.nsp;
authPayload = packet.data;
}
const { namespace, authPayload } = this._parseNamespace(packet);
const socket = this.nsps.get(namespace);
if (!socket && packet.type === PacketType.CONNECT) {
@@ -295,6 +286,20 @@ export class Client<
}
}
private _parseNamespace(packet: Packet) {
if (this.conn.protocol !== 3) {
return {
namespace: packet.nsp,
authPayload: packet.data,
};
}
const url = new URL(packet.nsp, "https://socket.io");
return {
namespace: url.pathname,
authPayload: Object.fromEntries(url.searchParams.entries()),
};
}
/**
* Handles an error.
*