github/socket.io
1
1
Fork 0
mirror of https://github.com/socketio/socket.io.git synced 2026-04-30 03:00:39 -04:00
Code Issues Packages Projects Releases Wiki Activity

refactor(eio): use hasOwn() method everywhere

Browse Source
This commit is contained in:
Damien Arrachequesne
2026-04-16 09:22:10 +02:00
parent 1fa1f46cd4
commit d4bc787731
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
packages/engine.io/lib/server.ts
View File

@@ -303,7 +303,7 @@ export abstract class BaseServer extends EventEmitter {
// sid check
const sid = req._query.sid;
if (sid) {
if (!this.clients.hasOwnProperty(sid)) {
if (!hasOwn(this.clients, sid)) {
debug('unknown sid "%s"', sid);
return fn(Server.errors.UNKNOWN_SID, {
sid,
@@ -403,9 +403,9 @@ export abstract class BaseServer extends EventEmitter {
*/
public close() {
debug("closing all open clients");
for (let i in this.clients) {
if (this.clients.hasOwnProperty(i)) {
this.clients[i].close(true);
for (const sid in this.clients) {
if (hasOwn(this.clients, sid)) {
this.clients[sid].close(true);
}
}
this.cleanup();